removed a bashism that prevented configuration

[oliverepper]

This time against aconfigure.ac.

[sauwming]

• I think it needs to be more complete than this, because just right above it there are quite a few that still uses +=.

• And to simplify it, instead of testing if [ -n "${ac_webrtc_aec3_cflags}" ]; everytime, perhaps it's simpler to just do one time initialisation of ac_webrtc_aec3_cflags="".

• Finally, the generated aconfigure also needs to be included in the PR.

[oliverepper]

I know there are a lot more += bashisms in the file, but this was the one preventing aconfigure from running on FreeBSD. The only one that needed fixing after adding | *amd64*freebsd* | *x86_64*freebsd* to the case statement. (Maybe I should include this, too).

There is no need to pre-initialise a variable in sh. You can simply do:

DEMO="${MAYBE_NON_EXISTANT} -Dimportant"

echo "${DEMO}"

I did the test to prevent the unnecessary and ugly whitespace in front of -Dimportant.

I have a newer version of autoconf installed. If I generate the aconfigure script there will be a bunch of unrelated changes.

Please allow me to derail this:
I am in the process of maintaining/updating the pjproject port for FreeBSD. I have a working port already, but a few things are not yet configurable. Giving the option --enable-libwebrtc-aec3 does not work right away. The above is one of the patches that are necessary. A few types must be adjusted, too. (pid_t is 4 bytes on FreeBSD).

Can we switch to email and discuss if a completely working port (all possible configurations) for FreeBSD is desirable and if I should create a branch to upstream all the necessary changes?

[sauwming]

You don't need to fix the entire file, but at least all the ac_webrtc_aec3_cflags, just to be consistent?

Sure, please feel free to drop us an email.

[oliverepper]

Ok. Perfect. Let's close this for now and I send you an email with a few questions and I will create a branch for what needs fixing for FreeBSD.