CI: change sleep_test() and timestamp_test() to exclusive on Windows #4246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… run last for slightly more efficient testing time
bennylp
changed the title
…rifts on GH Windows CI
bennylp
changed the title
sauwming
approved these changes
Jan 10, 2025
nanangizz
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pjlib-test's
sleep_test()often fails on Windows GH CI, sleeping for longer than tolerated, even with--ci-mode. Similarly,timestamp_test()also often fails, drifting for more than tolerated. This probably depends on the load of GH runner, because sometimes it works reliably for many days.As a workaround, this PR sets
sleep_test()andtimestamp_test()to run as exclusive test (=no other test will run while exclusive test is running) on Windows only.Also while at it, set exclusive tests in
pjlib-testto run last for slightly more efficient testing time