Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set CI vars in GH workflow file #4263

Merged
merged 8 commits into from
Jan 24, 2025
Merged

Set CI vars in GH workflow file #4263

merged 8 commits into from
Jan 24, 2025

Conversation

sauwming
Copy link
Member

Setting the variables in https://github.com/pjsip/pjproject/settings/variables/actions doesn't work for forks.
"They are not passed to workflows that are triggered by a pull request from a fork."

@sauwming sauwming self-assigned this Jan 23, 2025
@sauwming sauwming added this to the release-2.16 milestone Jan 23, 2025
@bennylp
Copy link
Member

bennylp commented Jan 23, 2025

Just to add that this changes #4014 in that we no longer use repository variables.

@bennylp bennylp self-requested a review January 23, 2025 07:05
@sauwming
Copy link
Member Author

Finally, it works

@sauwming sauwming merged commit de3f2e1 into master Jan 24, 2025
41 checks passed
@sauwming sauwming deleted the ci-vars branch January 24, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants