Added support for updated RFC7866 content-type sub type with XML extension #4270
+30
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sauwming
reviewed
Jan 27, 2025
| metadata_part = pjsip_multipart_find_part(rdata->msg_info.msg->body, | ||
| &media_type, NULL); | ||
|
|
||
| /* Fallback to XML extension rs-metadata+xml if needed */ |
There was a problem hiding this comment.
Why not just put this within pjsip_siprec_get_metadata()?
I know that you probably don't really need the function, but since it's already there, erasing it is typically not desirable unless really necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to support RFC7866 base content type XML extension per https://datatracker.ietf.org/doc/html/draft-sipcore-siprec-fix-mediatype-00