Minor modifications to Android build and samples to match new documentation #4271
+40
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tories when make distclean and realclean is called
…o codec priorities to use AMR-WB
sauwming
approved these changes
Jan 27, 2025
| @@ -20,10 +20,15 @@ import java.lang.ref.WeakReference | |||
| /* Configs */ | |||
|
|
|||
| // Account ID | |||
| const val ACC_ID_URI = "sip:localhost" | |||
| const val ACC_DOMAIN = "pjsip.org" | |||
| const val ACC_USER = "101" | |||
There was a problem hiding this comment.
usually we use test account here ("test"), also for the destination
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications to match new Android Getting Started documentation (see pjsip/pjproject_docs#26)
invoking
make distclean/realcleanfrom root diir will also invokedistclean/realcleanin:pjsip-apps/src/swigpjsip-apps/src/pjsua/android/jnifix pjsua CLI JNI Makefile:
armeabiarchitecturemodify Kotlin sample to make it nicer for showing off in Android Getting Started documentation: