Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacked pull request #59

Open
wants to merge 1 commit into
base: pkaminski-patch-3
Choose a base branch
from
Open

Conversation

pkaminski
Copy link
Owner

@pkaminski pkaminski commented Aug 15, 2016

This change is Reviewable

@pkaminski
Copy link
Owner Author

bar.txt, line 15 [r1] (raw file):

This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  

Let's add a new line on top of another PR.

A comment on the added line.


Comments from Reviewable

@pkaminski pkaminski changed the base branch from pkaminski-patch-3 to work August 15, 2016 21:22
@pkaminski pkaminski changed the base branch from work to pkaminski-patch-3 August 15, 2016 21:25
@pkaminski-test
Copy link
Collaborator

Review status: 0 of 1 files reviewed at latest revision, 3 unresolved discussions.


a discussion (no related file):
Normal request.


a discussion (no related file):
FYI request.


Comments from Reviewable

@pkaminski-test
Copy link
Collaborator

Review status: 0 of 1 files reviewed at latest revision, 5 unresolved discussions.


a discussion (no related file):
FYI again.


a discussion (no related file):
Normal again.


Comments from Reviewable

@pkaminski-test
Copy link
Collaborator

Review status: 0 of 1 files reviewed at latest revision, 6 unresolved discussions.


bar.txt, line 11 [r1] (raw file):


  /// Evaluates to `true` if system is direct feedthrough and `false` otherwise.
  // auto& input_vector = input_port.get_vector(context); // where the return is

FYI line.


Comments from Reviewable

@pkaminski-test
Copy link
Collaborator

Review status: 0 of 1 files reviewed at latest revision, 7 unresolved discussions.


bar.txt, line 13 [r1] (raw file):

  // auto& input_vector = input_port.get_vector(context); // where the return is

This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  This is a super long line that should wrap multiple times.  

Normal line.


Comments from Reviewable

@pkaminski
Copy link
Owner Author

a discussion (no related file):

Previously, pkaminski-test wrote…

Normal request.

Normal reply.

Comments from Reviewable

@pkaminski-test
Copy link
Collaborator

Review status: 0 of 1 files reviewed at latest revision, 7 unresolved discussions.


a discussion (no related file):

Previously, pkaminski (Piotr Kaminski) wrote…

Normal reply.

Another normal reply.

Comments from Reviewable

@pkaminski-test
Copy link
Collaborator

a discussion (no related file):

Previously, pkaminski-test wrote…

FYI again.

follow up

Comments from Reviewable

@pkaminski
Copy link
Owner Author

ads +invalid


Comments from Reviewable

@pkaminski
Copy link
Owner Author

+invalid


Comments from Reviewable

@pkaminski
Copy link
Owner Author

+invalid


Comments from Reviewable

@pkaminski pkaminski added the invalid Issue doesn't make sense label May 2, 2018
@pkaminski
Copy link
Owner Author

bar.txt, line 11 at r1 (raw file):


  /// Evaluates to `true` if system is direct feedthrough and `false` otherwise.
  // auto& input_vector = input_port.get_vector(context); // where the return is

A blocking comment from the author.


Comments from Reviewable

@pkaminski
Copy link
Owner Author

Review status: 0 of 1 files reviewed at latest revision, 8 unresolved discussions.


a discussion (no related file):
fyi this is an informing comment


Comments from Reviewable

@pkaminski
Copy link
Owner Author

Dismissed @pkaminski-test from a discussion.
Review status: 0 of 1 files reviewed at latest revision, 8 unresolved discussions.


a discussion (no related file):
Discussing initial comment from author.


a discussion (no related file):
Blocking initial comment from author.


Comments from Reviewable

@pkaminski-test
Copy link
Collaborator

Review status: 0 of 1 files reviewed at latest revision, 10 unresolved discussions.


a discussion (no related file):
FYI informing comment from reviewer.


a discussion (no related file):
Minor: discussing comment from reviewer.


a discussion (no related file):
A blocking comment from reviewer.


Comments from Reviewable

@pkaminski
Copy link
Owner Author

Review status: 0 of 1 files reviewed at latest revision, 12 unresolved discussions.


a discussion (no related file):

Previously, pkaminski-test wrote…

A blocking comment from reviewer.

Done.


a discussion (no related file):

Previously, pkaminski-test wrote…

Minor: discussing comment from reviewer.

Are you sure?


Comments from Reviewable

@pkaminski
Copy link
Owner Author

Review status: 0 of 1 files reviewed at latest revision, 12 unresolved discussions.


a discussion (no related file):
Old informational discussion.


Comments from Reviewable

@pkaminski
Copy link
Owner Author

Review status: 0 of 1 files reviewed at latest revision, 12 unresolved discussions.


a discussion (no related file):
Actual old informational discussion.


Comments from Reviewable

@pkaminski
Copy link
Owner Author

a discussion (no related file):

Previously, pkaminski-test wrote…

follow up

I meant to follow up.


Comments from Reviewable

@pkaminski
Copy link
Owner Author

Review status: 0 of 1 files reviewed at latest revision, 9 unresolved discussions.


a discussion (no related file):

Previously, pkaminski (Piotr Kaminski) wrote…

I meant to follow up.

Another followup.


Comments from Reviewable

@@ -11,3 +11,5 @@ Another bogus edit.
// auto& input_vector = input_port.get_vector(context); // where the return is
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a random comment coming from GitHub.

@pkaminski
Copy link
Owner Author

Top level follow up.


Comments from Reviewable

@pkaminski
Copy link
Owner Author

test ets


Comments from Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Issue doesn't make sense
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants