pkp/pkp-lib#6296 Article breadcrumbs use aria-current but do not point to the current page - OJS 3.4 #4133
Conversation
|
Hi @asmecher , could you please have a look and let me know if everything is fine? This PR fixes the main issue from this one: pkp/pkp-lib#6296 and also covers more improvements on ARIA attributes that were missing or misplaced. |
|
@jardakotesovec, could you review this? I'm probably the last person who should be looking at front-end markup :) |
|
@israelcefrin Thank you! Looks good to me. You mentioned that the aria-current should be used only on links? If thats the case, should not we also update the other cases to be links? For example if we go to /index.php/publicknowledge/about, than |
Hi @jardakotesovec , you are correct. And I am already tackling it , i.e. the top menu , on this issue: pkp/pkp-lib#5199 |
|
Hi @jardakotesovec , I've implemented the same feature on the breadcrumbs of OPS and OMP Default Theme breadcrumb template files. OPS 3.4 PR: pkp/ops#630 |
This PR fixes the issue pkp/pkp-lib#6296 and also implements:
aria-current="page"attribute was not being use on a link to the current pagearia-current="page"attribute from li element, it should to be used on link elements onlyaria-hidden="true"to the breadcrumb separators (they were announced as "slash" by screen readers which is annoying for screen reader users and don't add any information to the context)Even though showing the full article title might look overwhelming for sighted people, it is helpfull to people that rely on assistive technology like screen readers or screen magnifiers. They can double-check whether they are on the expected page through the breadcrumb interface element.