Skip to content

Commit

Permalink
Merge pull request #571 from jardakotesovec/i8919_vue3
Browse files Browse the repository at this point in the history
pkp/pkp-lib@8919 vue3 support adjustments
  • Loading branch information
jardakotesovec authored Oct 2, 2023
2 parents f5d17b3 + 9bc24bf commit 92fdf2b
Show file tree
Hide file tree
Showing 12 changed files with 6,374 additions and 18,608 deletions.
30 changes: 30 additions & 0 deletions .eslintrc.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
/* eslint-env node */
require("@rushstack/eslint-patch/modern-module-resolution");

module.exports = {
root: true,
env: {
node: true,
},
extends: [
"plugin:vue/vue3-essential",
"eslint:recommended",
"@vue/eslint-config-prettier/skip-formatting",
],
globals: {
$: true,
pkp: true,
},
parserOptions: {
ecmaVersion: "latest",
},
rules: {
"vue/multi-word-component-names": "off",
"no-unused-vars": [
"error",
{
args: "none",
},
],
},
};
4 changes: 4 additions & 0 deletions .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

npx lint-staged
3 changes: 3 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
cypress/tests/**/*
lib/pkp/cypress/**/*
package.json
2 changes: 1 addition & 1 deletion cypress/tests/data/60-content/CmontgomerieSubmission.cy.js
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ describe('Data suite: Cmontgomerie', function() {

// Edit metadata in 1st version
cy.get('#metadata-button').click();
cy.get('#metadata-keywords-control-en').type('employees{enter}', {delay: 0});
cy.get('#metadata-keywords-control-en').type('employees{enter}');
cy.wait(500);
cy.get('#metadata-keywords-control-en').type('{enter}', {delay: 0});
cy.get('#metadata button').contains('Save').click();
Expand Down
7 changes: 2 additions & 5 deletions js/load.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ import FailedJobsPage from '@/components/Container/FailedJobsPage.vue';
import FailedJobDetailsPage from '@/components/Container/FailedJobDetailsPage.vue';
import SubmissionsPage from '@/components/Container/SubmissionsPage.vue';

// Required by the URN plugin
import FieldText from '@/components/Form/fields/FieldText.vue';
// styles
import '@/styles/_global.less';

// Expose Vue, the registry and controllers in a global var
window.pkp = Object.assign(PkpLoad, {
Expand Down Expand Up @@ -62,6 +62,3 @@ window.pkp = Object.assign(PkpLoad, {
SubmissionsPage,
},
});

// Required by the URN plugin
window.pkp.Vue.component('field-text', FieldText);
Loading

0 comments on commit 92fdf2b

Please sign in to comment.