fix range tcp flags and help messages

Signed-off-by: Keith Wiles <[email protected]>
pktgen · Oct 31, 2023 · 98b6d98 · 98b6d98
1 parent 2bfcdc3
commit 98b6d98
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-23.10.1
+23.10.2
diff --git a/app/cli-functions.c b/app/cli-functions.c
@@ -167,6 +167,8 @@ static const char *range_help[] = {
     "       or  range 0 dst ip 0.0.0.0 0.0.0.0 1.2.3.4 0.0.1.0",
     "range <portlist> type ipv4|ipv6               - Set the range packet type to IPv4 or IPv6",
     "range <portlist> proto tcp|udp                - Set the IP protocol type",
+    "range <portlist> tcp flag set <flag>          - Set the TCP flag",
+    "range <portlist> tcp flag clr <flag>          - Clear the TCP flag",
     "range <portlist> tcp seq <SMMI> <value>       - Set the TCP sequence number",
     "       or  range <portlist> tcp seq <start> <min> <max> <inc>",
     "range <portlist> tcp ack <SMMI> <value>       - Set the TCP acknowledge number",

diff --git a/app/pktgen-cmds.c b/app/pktgen-cmds.c
@@ -3416,7 +3416,8 @@ single_set_tcp_flag_clr(port_info_t *info, const char *which)
 void
 range_set_tcp_flag_set(port_info_t *info, const char *which)
 {
-    info->seq_pkt[RANGE_PKT].tcp_flags |= tcp_flag_from_str(which);
+    info->range.tcp_flags |= tcp_flag_from_str(which);
+    info->seq_pkt[RANGE_PKT].tcp_flags = info->range.tcp_flags;
 }
 
 /**
@@ -3434,7 +3435,8 @@ range_set_tcp_flag_set(port_info_t *info, const char *which)
 void
 range_set_tcp_flag_clr(port_info_t *info, const char *which)
 {
-    info->seq_pkt[RANGE_PKT].tcp_flags &= ~tcp_flag_from_str(which);
+    info->range.tcp_flags &= ~tcp_flag_from_str(which);
+    info->seq_pkt[RANGE_PKT].tcp_flags = info->range.tcp_flags;
 }
 
 /**

diff --git a/changelog.txt b/changelog.txt
@@ -6,6 +6,7 @@ Pktgen-DPDK - Traffic Generator powered by DPDK
 ** (Pktgen) Sounds like 'Packet-Gen'**
 
 **=== Modifications ===**
+ - 23.10.2 - Fix range tcp flags and help messages
  - 23.10.1 - Fix rte_thread_setname() change to rte_thread_set_name() for lua builds
  - 23.10.0 - Change TX rate calculations to be more accurate
              Change timer routines to use DPDK timer manager