Support Faraday 1.0+, fix issue with non-raised server errors (50X) #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In its 1.0 release, Faraday split `Response::RaiseError::ClientErrorStatuses` apart into a second `ServerErrorStatuses` constant. This gem relied on `ClientErrorStatuses` to return `400...600`, but it returns `400...500` instead. This change decouples Plaid's middleware from Faraday's internal constants, such that both pre-1.0 and post-1.0 versions of Faraday should be supported.
smudge
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In its 1.0 release, Faraday split
Response::RaiseError::ClientErrorStatusesapart into a secondServerErrorStatusesconstant.This gem relied on
ClientErrorStatusesreturning400...600, but now it returns400...500instead. This means that if Plaid's API returns a 50X code, and the consuming application is running Faraday 1.0+, no Ruby error will raise and code execution will continue as if a successful response had been returned.This change decouples Plaid's middleware from Faraday's internal constants, such that both pre-1.0 and post-1.0 versions of Faraday should be supported.