Sockets fixed #462
Open
Sockets fixed #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 2, 2016 11:11
Sockets are abstracted in `socket.ts`, and I have implemented them for Node and Websockify. This cleans up our native methods. The TCPTest works in Node but fails in the browser. The Websockify JavaScript library needs some loving. It assumes that it is running in the main browser context and spews global variables all over the place. I've made some adjustments, but it seems like it may be worth reimplementing in TypeScript in a more modular fashion. I have it working in the Worker context for the unit tests, but it fails to properly do the Websockify handshake.
Not strenuously tested yet, but work with a simple "HELLO WORLD".
This was referenced Jun 6, 2016
added 2 commits
June 6, 2016 21:25
…in webworkers. Should fix TravisCI build.
added 10 commits
October 30, 2016 15:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits refactor and fix our implementation of TCP sockets. It also adds a server and client for testing purposes, so we can make sure that the sockets do not get broken again!
TODO before merge: