Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please ignore: Preview environment for has_done/has_not_done filters #4995

Draft
wants to merge 34 commits into
base: master
Choose a base branch
from
Draft

Please ignore: Preview environment for has_done/has_not_done filters #4995

wants to merge 34 commits into from

Conversation

macobo
Copy link
Contributor

@macobo macobo commented Jan 21, 2025 •
edited
Loading

Nothing to review here - putting a branch up for the review environment.

For Marko, in this branch:

  • Event filters (goal, page, hostname, props) support has done/has not done operations. These are limited per-session
    • Note this may play funky with what metrics may or may not be displayed, no work has been done to clear that up.
  • You can add multiple filters of each type for ease of testing

macobo added 30 commits January 21, 2025 09:34
@macobo
Expose site_id and site_native_stats_start_at via query
ff9a8e9 
This allows to do more query-building without exposing and passing `site` directly.
@macobo
Very basic has_done/has_done_not operator support
37784a8 
No event:goal support yet, no validations
@macobo
Add validations that only event: dimensions can be used within has_do…
efced25 
…ne/has_done_not
@macobo
Allow event:goal filters nested within has_done/has_done_not behavior…
4109b4e 
…al filters
@macobo
Minor fix for do_decide_custom_prop_table
aa6eeee
@macobo
has_done support for goals
871c76e 
Minor changes along the way:
- preloaded_goals structure changes
- event:goal restrictions were loosened within has_done
- we don't allow nesting has_done anymore
@macobo
Dont query imports when behavioral filters are present
675ddc9
@macobo
Update callsites of filtering_on_dimension? to work with new behavior…
cbf7b32 
…al filters
@macobo
has_done_not -> has_not_done
72a339e
@macobo
Changelog entry
d6155ea
@macobo
Typegen
5170a80
@macobo
credo cleanup
36420ac
@macobo
Fix changelog
bc314ef
@macobo
Remove changelog
83aa4cb
@macobo
Mark has_done as internal-only
ced32da
@macobo
combine two validations into a single loop
59ec12d
@macobo
has_done is now session-based not user-based
02e274d
@macobo
Update a test
6d57cfe
@macobo
Simple frontend for has_done_not
a52faa6
@macobo
Simple UI for goal filter adding or removal
de8976b
@macobo
Better alignment on trash icons, avoid moving around if row expands
cff2739
@macobo
Refactor filter text functions, share code
204565e
@macobo
has_not_done, special casing for has not done when formatting filter …
2d20918 
…text
@macobo
Changelog
2333399
@macobo
Fix lint
1f0f4b8
@macobo
prettier format
14dd9e3
@macobo
Add tests
5842468
@macobo
Lowercase Goal
97d00b8
@macobo
Update changelog
1f9f34a
@macobo
has_not_done for goals is now named is not in the UI
e39a7ee
@macobo macobo added the preview label Jan 21, 2025
@github-actions GitHub Actions
Copy link

Preview environment👷🏼‍♀️🏗️
PR-4995

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
preview
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@macobo