Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to jackson 2.12.3 #633

Closed
wants to merge 2 commits into from
Closed

Upgrade to jackson 2.12.3 #633

wants to merge 2 commits into from

Conversation

gheine
Copy link

@gheine gheine commented Jun 23, 2021

Fixes #632

@SethTisue SethTisue self-assigned this Jun 23, 2021
@SethTisue SethTisue removed their assignment Jun 24, 2021
@ndeverge
Copy link
Member

It would be great to merge this one in order to fix CVE-2020-36518.

Thanks

@mkurz
Copy link
Member

mkurz commented Mar 28, 2022

I am interested what the akka team will do, because they are stuck on Jackson 2.11... I am tracking akka/akka#31282 and akka/akka#31281 (which upgrades Jackson only when on Scala 3 however).
If akka don't upgrade, we might finally consider upgrading it for Play though, even in 2.8.x, which should not break akka (but maybe apps?), see akka/akka#31097 (comment):

jackson changed between 2.11.4 and 2.13.1. While we don't rely on any of the parts that changed, so Akka works fine with 2.13.1, there could be projects using Akka that do rely on the 2.11 behavior. For that reason we're reluctant to update jackson in Akka, since that might force projects to also update, which might not be easy.

@mkurz
Copy link
Member

mkurz commented Apr 5, 2022

Please have a look my comment in #740, for the next major release IMHO it now makes sense to upgrade to latet Jackson for play-json and play itself.

@mkurz mkurz closed this Apr 5, 2022
@mkurz
Copy link
Member

mkurz commented Apr 5, 2022

For CVE-2020-36518 however I think users should upgrade the dependency themselves... Since I don't want to introduce breaking changes into production apps... So everyone has to test carefully. I will write an announcement about the CVE-2020-36518 in the GitHub Discussions soon.

@mkurz
Copy link
Member

mkurz commented Apr 6, 2022

@ndeverge Please see playframework/playframework#11222 regarding CVE-2020-36518.

@ndeverge
Copy link
Member

ndeverge commented Apr 7, 2022

Thanks @mkurz, it's perfectly clear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Jackson 2.12.x
4 participants