Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cnam-storage sdk changes #181

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

cnam-storage sdk changes #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d4367ba
added cnam-storage changes
prabhav-plivo Jul 26, 2023
469b1da
removed print statements
prabhav-plivo Jul 26, 2023
8413f8d
showing message prior to api id
prabhav-plivo Jul 27, 2023
70fab11
added cnam field in tests
prabhav-plivo Jul 28, 2023
7caa20a
changed var callbackUrl
prabhav-plivo Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions fixtures/numberGetResponse.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"api_id": "88625e5e-1c92-11e4-80aa-12313f048015",
"application": "/v1/Account/MANWVLYTK4ZWU1YTY4ZT/Application/29986316244302815/",
"carrier": "Plivo",
"cnam": "plivo",
"cnam_lookup":"enabled",
"monthly_rental_rate": "0.80000",
"number": "17609915566",
Expand Down
3 changes: 3 additions & 0 deletions fixtures/numberListResponse.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"alias": null,
"application": "/v1/Account/MANWVLYTK4ZWU1YTY4ZT/Application/29986316244302815/",
"carrier": "Plivo",
"cnam": "plivo",
"cnam_lookup":"enabled",
"monthly_rental_rate": "0.80000",
"number": "18135401302",
Expand All @@ -34,6 +35,7 @@
"alias": "",
"application": "/v1/Account/MANWVLYTK4ZWU1YTY4ZT/Application/16632559604105954/",
"carrier": "Plivo",
"cnam": "",
"cnam_lookup":"enabled",
"monthly_rental_rate": "0.80000",
"number": "14153661106",
Expand All @@ -55,6 +57,7 @@
"alias": "",
"application": "/v1/Account/MANWVLYTK4ZWU1YTY4ZT/Application/20372631212782799/",
"carrier": "Plivo",
"cnam": "plivo",
"cnam_lookup":"disabled",
"monthly_rental_rate": "0.80000",
"number": "14152753408",
Expand Down
36 changes: 26 additions & 10 deletions numbers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ type Number struct {
Application string `json:"application,omitempty" url:"application,omitempty"`
RenewalDate string `json:"renewal_date,omitempty" url:"renewal_date,omitempty"`
CNAMLookup string `json:"cnam_lookup,omitempty" url:"cnam_lookup,omitempty"`
CNAM string `json:"cnam,omitempty" url:"cnam,omitempty"`
AddedOn string `json:"added_on,omitempty" url:"added_on,omitempty"`
ResourceURI string `json:"resource_uri,omitempty" url:"resource_uri,omitempty"`
VoiceRate string `json:"voice_rate,omitempty" url:"voice_rate,omitempty"`
Expand All @@ -40,13 +41,22 @@ type NumberCreateParams struct {
}

type NumberCreateResponse BaseResponse
type NumberUpdateResponse BaseResponse

type NumberUpdateResponse struct {
Message string `json:"message" url:"message"`
ApiId string `json:"api_id" url:"api_id"`
NewCnam string `json:"new_cnam,omitempty"`
CNAMUpdateStatus string `json:"cnam_update_status,omitempty"`
}

type NumberUpdateParams struct {
AppID string `json:"app_id,omitempty" url:"app_id,omitempty"`
Subaccount string `json:"subaccount,omitempty" url:"subaccount,omitempty"`
Alias string `json:"alias,omitempty" url:"alias,omitempty"`
CNAMLookup string `json:"cnam_lookup,omitempty" url:"cnam_lookup,omitempty"`
AppID string `json:"app_id,omitempty" url:"app_id,omitempty"`
Subaccount string `json:"subaccount,omitempty" url:"subaccount,omitempty"`
Alias string `json:"alias,omitempty" url:"alias,omitempty"`
CNAMLookup string `json:"cnam_lookup,omitempty" url:"cnam_lookup,omitempty"`
CNAM string `json:"cnam,omitempty" url:"cnam,omitempty"`
CallbackURL string `json:"callback_url"`
CallbackMethod string `json:"callback_method"`
}

type NumberListParams struct {
Expand All @@ -66,6 +76,7 @@ type NumberListParams struct {
TendlcRegistrationStatus string `json:"tendlc_registration_status,omitempty" url:"tendlc_registration_status,omitempty"`
TollFreeSMSVerification string `json:"toll_free_sms_verification,omitempty" url:"toll_free_sms_verification,omitempty"`
CNAMLookup string `json:"cnam_lookup,omitempty" url:"cnam_lookup,omitempty"`
CNAM string `json:"cnam,omitempty" url:"cnam,omitempty"`
}

type NumberListResponse struct {
Expand Down Expand Up @@ -159,8 +170,11 @@ type PhoneNumberListParams struct {
}

type PhoneNumberCreateParams struct {
AppID string `json:"app_id,omitempty" url:"app_id,omitempty"`
CNAMLookup string `json:"cnam_lookup,omitempty" url:"cnam_lookup,omitempty"`
AppID string `json:"app_id,omitempty" url:"app_id,omitempty"`
CNAMLookup string `json:"cnam_lookup,omitempty" url:"cnam_lookup,omitempty"`
CNAM string `json:"cnam,omitempty" url:"cnam,omitempty"`
CallbackURL string `json:"callback_url"`
CallbackMethod string `json:"callback_method"`
}

type PhoneNumberService struct {
Expand All @@ -171,9 +185,11 @@ type PhoneNumberCreateResponse struct {
APIID string `json:"api_id" url:"api_id"`
Message string `json:"message" url:"message"`
Numbers []struct {
Number string `json:"number" url:"number"`
Status string `json:"status" url:"status"`
} `json:"numbers" url:"numbers"`
Number string `json:"number" url:"number"`
Status string `json:"status" url:"status"`
NewCnam string `json:"new_cnam,omitempty"`
CNAMUpdateStatus string `json:"cnam_update_status,omitempty"`
} `json:"numbers"`
Status string `json:"status" url:"status"`
}

Expand Down