Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce option to automatically use sequens, sequentes in postnote (#217) #1392

Merged
merged 12 commits into from
Nov 13, 2024

Conversation

jspitz
Copy link
Contributor

@jspitz jspitz commented Nov 1, 2024

This entails new formatting commands \mkseqrange[*] and \mkseqornormrange[*] as well as a new option
pageseq=none|two+|three+|all+

The lexic of the latter is adapted from backrefstyle.

These are supported by Babel as swissgerman and nswissgerman, by
polyglossia als german, variant=swiss (spelling=old|new)

Also, correct a string in german.lbx which has erroneously been changed
to follow new orthography
…217)

This entails new formatting commands \mkseqrange[*]
and \mkseqornormrange[*] as well as a new option
pageseq=none|two+|three+|all+

The lexic of the latter is adapted from backrefstyle.
@jspitz jspitz changed the title Introduce option to automatically use sequens, sequentis in postnote (#217) Introduce option to automatically use sequens, sequentes in postnote (#217) Nov 1, 2024
@jspitz
Copy link
Contributor Author

jspitz commented Nov 3, 2024

An afterthought: We could also generalize the option a bit more to provide even more convenience:

  • rename proposed macro \mkseqornormrange => \mkautorange
  • make it also consider \mkcomprange
  • rename proposed option pageseq => citepagerange with values normalized (default), compressed, 2sq, 3sqq, allsqq

I think this would be a useful interface. What do you think?

Also add warning on invalid value
If we provide an option to select page range formats, we should also
include mkcomprange. Hence:
* rename macro `\mkseqornormrange` => `\mkautorange`
* make it also consider `\mkcomprange`
* rename proposed option `pageseq` => `citepagerange` with values
  `normalized` (default), `compressed`, `2sq`, `3sqq`, `allsqq`
@jspitz
Copy link
Contributor Author

jspitz commented Nov 4, 2024

I have updated my pull request to include the extensions proposed in #1392 (comment)

@jspitz
Copy link
Contributor Author

jspitz commented Nov 4, 2024

BTW as far as I can see the reason for the checks failing is a biblatex/biber version mismatch in dev branch.

@moewew
Copy link
Collaborator

moewew commented Nov 12, 2024

Looks nice. Thank you very much. I'd like to squash and merge to keep the history a bit nicer. Would that mess things up hugely on your end?

@jspitz
Copy link
Contributor Author

jspitz commented Nov 13, 2024

I think I can deal with it. It's better for me to do a completely new fork after this has been merged anyway in order to start from a clean history.

@moewew moewew merged commit 4c9a2a8 into plk:dev Nov 13, 2024
1 check failed
@moewew
Copy link
Collaborator

moewew commented Nov 13, 2024

Nice. Merged.

(I guess it is probably easier to work on feature branches in future, then you don't need to worry too much about what's going on on dev.)

For the link: #217.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants