Fix docs spelling #152
Open
Fix docs spelling #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution @nnsW3! |
eyqs
reviewed
Jan 10, 2025
| @@ -6,7 +6,7 @@ pragma solidity 0.8.25; | |||
| * @author Eugene Y. Q. Shen | |||
| * @notice Empty contract that has nothing in it and does nothing | |||
| * @dev This empty contract is used as the initial implementation contract | |||
| * when deploying new proxy contracts to ensure that the addresses all | |||
| * when deploying new proxy contracts ensure that the addresses all | |||
| @@ -230,7 +230,7 @@ contract AssetVault is WalletUtils, IAssetVault { | |||
| /** | |||
| * @notice Redistribute yield to the beneficiaries of the AssetToken, using yield distributions | |||
| * @dev Only the user wallet can initiate the yield redistribution. The yield redistributed | |||
| * to each beneficiary is rounded down, and any remaining CurrencyToken are kept in the vault. | |||
| * to each beneficiary is rounded down, and any remaining CurrencyToken is kept in the vault. | |||
| @@ -348,7 +348,7 @@ contract AssetVault is WalletUtils, IAssetVault { | |||
| return; | |||
| } | |||
|
|
|||
| // Look for existing distribution with same beneficiary and expiration | |||
| // Look for existing distribution with the same beneficiary and expiration | |||
There was a problem hiding this comment.
This is unnecessary in a short comment
| @@ -129,7 +129,7 @@ contract SignedOperations is EIP712, WalletUtils, ISignedOperations { | |||
|
|
|||
| /** | |||
| * @notice Cancel pending SignedOperations that have not yet been executed | |||
| * @dev This function can only be called by the user that signed the SignedOperations. | |||
| * @dev This function can only be called by the user who signed the SignedOperations. | |||
There was a problem hiding this comment.
The user may not be a person (e.g. automated system), so "that" is appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
While looking through your docs I found and fixed several spelling issues.
Br, Elias.