Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PDE-683] fix compilation issues for AssetToken / YieldToken #157

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[PDE-683] fix compilation issues for AssetToken / YieldToken #157

wants to merge 4 commits into from

Conversation

ungaro
Copy link
Member

@ungaro ungaro commented Jan 22, 2025

What's new in this PR?

fix compilation issues for AssetToken / YieldToken

@ungaro ungaro requested a review from eyqs January 22, 2025 22:27
eyqs
eyqs approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@eyqs eyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change onlyOwner to onlyRole(ADMIN_ROLE)

smart-wallets/src/token/YieldDistributionToken.sol Outdated
@@ -3,14 +3,14 @@ pragma solidity ^0.8.25;

import { OwnableUpgradeable } from "@openzeppelin/contracts-upgradeable/access/OwnableUpgradeable.sol";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get rid of ownable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyqs eyqs eyqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ungaro @eyqs