[PDE-691] staking contract for nYIELD #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyqs
reviewed
Jan 28, 2025
…some optimizations
|
PTAL @qubitcrypto @eyqs |
qubitcrypto
approved these changes
Feb 4, 2025
qubitcrypto
requested changes
Feb 5, 2025
| /** | ||
| * @notice Initialize the contract. | ||
| * @param timelock The timelock contract address. | ||
| * @param owner The owner address. |
There was a problem hiding this comment.
Be explicit who the owner is? the deployer? a multisig contract address?
| function reinitialize(address multisig, TimelockController timelock) public reinitializer(2) onlyRole(ADMIN_ROLE) { | ||
| BoringVaultPredepositStorage storage $ = _getBoringVaultPredepositStorage(); | ||
| $.multisig = multisig; | ||
| $.timelock = timelock; |
There was a problem hiding this comment.
At this point, the contract's super admin role and admin role is still the "owner", potentially the deployer.
All the following functions requires "ADMIN_ROLE" which has nothing to do with this multisig we set here.
If I understand our intention correctly, we must revoke and grant roles with reinitialize(), and emitting events accordingly:
// Transfer administrative roles
address oldAdmin = getRoleMember(DEFAULT_ADMIN_ROLE, 0);
_revokeRole(DEFAULT_ADMIN_ROLE, oldAdmin);
_revokeRole(ADMIN_ROLE, oldAdmin);
_grantRole(DEFAULT_ADMIN_ROLE, multisig);
_grantRole(ADMIN_ROLE, multisig);
emit MultisigSet(multisig);
emit TimelockSet(address(timelock));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
add nYield pre-deposit contract