Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: index.html renaming of README.md #214

Merged
merged 4 commits into from
Feb 7, 2025
Merged

fix: index.html renaming of README.md #214

merged 4 commits into from
Feb 7, 2025

Conversation

Autoparallel
Copy link
Contributor

This makes links work across book and repo./

@mrdaybird
Copy link
Contributor

mdbook-linkcheck does not seem to be working.

ronkathon/book.toml

Lines 19 to 21 in 38f2b1b

[preprocessor.linkcheck]
follow-web-links =true
traverse-parent-directories=true

[preprocessor.linkcheck] should be [output.linkcheck]

After this change, mdbook-linkcheck gives a couple of errors and a bunch of warning...

@Autoparallel
Copy link
Contributor Author

Good catch, @mrdaybird -- as always

@Autoparallel
Copy link
Contributor Author

man what the hell. these links should be fine

@Autoparallel
Copy link
Contributor Author

@0xJepsen @lonerapier can we get a review and merge? I don't care that the arkworks link is broken in the test. That is just dumb.

Copy link
Contributor

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, i whitelisted the arkworks link, thats weird it was causing a failure

@0xJepsen 0xJepsen merged commit cbfe9f1 into main Feb 7, 2025
6 checks passed
@0xJepsen 0xJepsen deleted the fix/simple-link-fix branch February 7, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants