Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: HTTP parser #86

Merged
merged 2 commits into from
Jan 15, 2025
Merged

fix: HTTP parser #86

merged 2 commits into from
Jan 15, 2025

Conversation

Autoparallel
Copy link
Contributor

@Autoparallel Autoparallel commented Dec 19, 2024 •
edited
Loading

Basically, we just needed to enforce that we only use a colon : as a parser instruction when we're not inside a header's value. All seems well now.

  • Test to check this works properly, see npx mocha -g "HTTP Parser"

@Autoparallel
fix: http parser
ba27970 
Includes a test to check this works properly
@Autoparallel
Update package.json
db1de62
lonerapier
lonerapier approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@lonerapier lonerapier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. let's merge this!!!

@Autoparallel Autoparallel merged commit d8de532 into main Jan 15, 2025
3 checks passed
@Autoparallel Autoparallel deleted the fix/http-parsing branch January 15, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonerapier lonerapier lonerapier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Autoparallel @lonerapier