Improve ease of use without threads, get rid of ServerEventSource #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this leaves the responsibility of reading packets and ticking the server up to the user, which allows for more dynamic ticking, custom sleep mechanisms (perhaps RakLib is to share a thread with something else), and easier API use when used without threads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this leaves the responsibility of reading packets and ticking the server up to the user, which allows for more dynamic ticking, custom sleep mechanisms (perhaps RakLib is to share a thread with something else), and easier API use when used without threads.
However it is somewhat less convenient in the sense that consumers of the library must now come up with their own ticking mechanism rather than having RakLib do it for them.
Not sure if this is finished or not, but it was made with the following issues in mind:
pmmp/PocketMine-MP#6333
pmmp/PocketMine-MP#6294
Basically this means that
tickProcessor()would be moved inline here: https://github.com/pmmp/PocketMine-MP/blob/06028aac97d876ce3ef249d64f70013b2f76d1c1/src/network/mcpe/raklib/RakLibServer.php#L106-L108allowing more control over when the server sleeps and the way in which messages are delivered to the server instance