fix: derived atom is not recomputed after its dependencies changed #2906

[dmaskasky]

Related Bug Reports or Discussions

#2906

Summary

When a writable atom sets two different atoms, and another atom indirectly depends on both, the dependent atom may fail to update correctly. Specifically, if the first atom's update results in no actual change, the dependent atom's "dirty bit" gets cleared prematurely. Then, when the second finishRecompute executes, the dependent atom does not recompute because its dirty bit was already cleared.

The proposed solution in this PR is to consolidate all finishRecompute operations into a single process, thereby handling changes to the atom graph in one go.

Check List

• pnpm run prettier for formatting code and docs

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
jotai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 8, 2025 5:21am

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

[pkg-pr-new]

Open in Stackblitz

More templates

• hacker_news
• starter
• hello
• text_length
• todos
• todos_with_atomFamily
• mega-form

npm i https://pkg.pr.new/jotai@2907

commit: 8ebb8f0

[github-actions]

Preview in LiveCodes

Latest commit: 8ebb8f0
Last updated: Jan 8, 2025 5:20am (UTC)

Playground	Link
React demo	https://livecodes.io?x=id/CYQ9FAJAH

---

See documentations for usage instructions.

[github-actions]

Size Change: +334 B (+0.36%)

Total Size: 92.4 kB

Filename	Size	Change
./dist/esm/vanilla.mjs	4.27 kB	+52 B (+1.23%)
./dist/system/vanilla.development.js	4.37 kB	+55 B (+1.28%)
./dist/system/vanilla.production.js	2.22 kB	+48 B (+2.21%)
./dist/umd/vanilla.development.js	5.75 kB	+67 B (+1.18%)
./dist/umd/vanilla.production.js	2.91 kB	+49 B (+1.71%)
./dist/vanilla.js	5.63 kB	+63 B (+1.13%)

ℹ️ View Unchanged

Filename	Size
./dist/babel/plugin-debug-label.js	932 B
./dist/babel/plugin-react-refresh.js	1.14 kB
./dist/babel/preset.js	1.41 kB
./dist/esm/babel/plugin-debug-label.mjs	1 kB
./dist/esm/babel/plugin-react-refresh.mjs	1.19 kB
./dist/esm/babel/preset.mjs	1.49 kB
./dist/esm/index.mjs	62 B
./dist/esm/react.mjs	1.4 kB
./dist/esm/react/utils.mjs	746 B
./dist/esm/utils.mjs	67 B
./dist/esm/vanilla/utils.mjs	5.04 kB
./dist/index.js	242 B
./dist/react.js	1.44 kB
./dist/react/utils.js	1.39 kB
./dist/system/babel/plugin-debug-label.development.js	1.1 kB
./dist/system/babel/plugin-debug-label.production.js	775 B
./dist/system/babel/plugin-react-refresh.development.js	1.29 kB
./dist/system/babel/plugin-react-refresh.production.js	928 B
./dist/system/babel/preset.development.js	1.59 kB
./dist/system/babel/preset.production.js	1.14 kB
./dist/system/index.development.js	252 B
./dist/system/index.production.js	183 B
./dist/system/react.development.js	1.56 kB
./dist/system/react.production.js	864 B
./dist/system/react/utils.development.js	860 B
./dist/system/react/utils.production.js	462 B
./dist/system/utils.development.js	257 B
./dist/system/utils.production.js	187 B
./dist/system/vanilla/utils.development.js	5.25 kB
./dist/system/vanilla/utils.production.js	3.14 kB
./dist/umd/babel/plugin-debug-label.development.js	1.08 kB
./dist/umd/babel/plugin-debug-label.production.js	852 B
./dist/umd/babel/plugin-react-refresh.development.js	1.27 kB
./dist/umd/babel/plugin-react-refresh.production.js	1 kB
./dist/umd/babel/preset.development.js	1.54 kB
./dist/umd/babel/preset.production.js	1.22 kB
./dist/umd/index.development.js	383 B
./dist/umd/index.production.js	328 B
./dist/umd/react.development.js	1.57 kB
./dist/umd/react.production.js	936 B
./dist/umd/react/utils.development.js	1.53 kB
./dist/umd/react/utils.production.js	1.01 kB
./dist/umd/utils.development.js	399 B
./dist/umd/utils.production.js	342 B
./dist/umd/vanilla/utils.development.js	6.24 kB
./dist/umd/vanilla/utils.production.js	3.78 kB
./dist/utils.js	247 B
./dist/vanilla/utils.js	6.1 kB

_{compressed-size-action}

[dai-shi]

Thanks for working on it! I'll have a deeper look later.

[dai-shi]

This does seem to fix the issue, but as you might expected it, I'm not a big fan of this change. (And, I didn't like .D already, so I want to find alternative way in the future.) I'll look for some other solutions. Give me some time.