Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rust implementation #1

Draft
wants to merge 53 commits into
base: master
Choose a base branch
from
Draft

Add rust implementation #1

wants to merge 53 commits into from

Conversation

pnyda
Copy link
Owner

@pnyda pnyda commented Jan 27, 2025 •
edited
Loading

Done

  • CCS
  • CCS+

TODO

  • Currently I'm checking whether the lookup relations in CCS+ satisfies or not naively. I'll implement succinct check using Halo2 lookup argument

pnyda added 30 commits January 27, 2025 17:46
@pnyda
Depend on sonobe
def70b6
@pnyda
Extract necessary information from a fibonacci circuit
4614511
@pnyda
Generate a list of monomials from Expression
954daf5
@pnyda
Generate the cell mapping
6b36209
@pnyda
Introduce AbsoluteCellPosition and CCSValue
7750ebe 
This is needed to make cell_mapping able to represent a copy constraint from an advice cell to a fixed cell
@pnyda
Refactoring: generate_cell_mapping should not rely on monomials. It's…
4d16893 
… generate_mj's job
@pnyda
Incorporate copy constraints into generate_cell_mapping
5257ade
@pnyda
Implement generate_mj
3bca3db
@pnyda
Implement generate_ccs_instance
6dde3d5
@pnyda
bugfix: We can't generate Z when some of z_index is unused
58aaa6b
@pnyda
Implement generate_z
f3d44d1
@pnyda
Write a test for fibonacci satisfiabilty
a0b8dd9
@pnyda
bugfix: an instance cell in Z was overridden by the value in an advic…
1a05289 
…e cell when there is copy constraint between the two
@pnyda
bugfix: it wasn't able to keep track of z_index reassignment correctly
9ae14f7
@pnyda
Make the test pass
2128561
@pnyda
Calculate l properly
e3ffd0b
@pnyda
Calculate d properly
2dc88c6
@pnyda
Make CCSValue generic
3de6b52
@pnyda
Use ark_ff::PrimeField instead of halo2::PrimeField in Monomial
250f135
@pnyda
Make everything generic as possible
977aa26
@pnyda
Add a test for failure case
8f209a7
@pnyda
Move test circuit into mod tests
38e4bed
@pnyda
Suppress warnings
f90ecb5
@pnyda
Support multiple custom gates
2b5868d
@pnyda
Found a failing test case
23d991d
@pnyda
bugfix: a cell with greater ordering will get deduplicated into a cel…
f49fc6d 
…l with less ordering. It means that a cell with less ordering must determine the value of Z when a single element of Z represents multiple cells
@pnyda
Rename
21acc1a
@pnyda
bugfix: incorrect m
ccdb4ce
@pnyda
bugfix: we were testing different circuit...
62fa095
@pnyda
Refactoring: We should not implement the same ordering rule in 2 diff…
bc531c5 
…erent places
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pnyda