Reimplement enum inspector via spy #296
Open
+106
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since ruby-3.5, the benchmark gem has been moved to the bundled gem from default gems. Therefore it should be loaded explicitly in Gemfile. https://bugs.ruby-lang.org/issues/20309
The signatures of Rake::TaskLib has been registered to gem_rbs_collection. Thefore custom types are no longer needed. ref: https://github.com/ruby/gem_rbs_collection/blob/main/gems/rake/13.0/rake.rbs
So far, enum inspector has been implemented by static code analysis. But it is a bit fragile and difficult to maintain. This reimplements the inspector by spy technique. The new inspector collects the enums definitions on loading ActiveRecord models. Note: The new enum inspector must be installed before ActiveRecord models loading.
|
@pocke Could you review this, please? I implemented this relying on my memory because I lost the URL of your design doc. I hope this is matched to what you expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, enum inspector has been implemented by static code analysis.
But it is a bit fragile and difficult to maintain.
This reimplements the inspector by spy technique. The new inspector
collects the enums definitions on loading ActiveRecord models.
Note: The new enum inspector must be installed before ActiveRecord
models loading.
Note: This includes #294 and #295