Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(active_record::generator): #pk_type fails when model has composit… #298

Closed
wants to merge 1 commit into from
Closed

fix(active_record::generator): #pk_type fails when model has composit… #298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions lib/rbs_rails/active_record.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,16 @@ def generate
pk = klass.primary_key
return 'top' unless pk

col = klass.columns.find {|col| col.name == pk }
sql_type_to_class(col.type)
if pk.is_a?( String)
col = klass.columns.find {|col| col.name == pk }
sql_type_to_class(col.type)
elsif pk.is_a?(Array)
pk_types = pk.map do |pkc|
col = klass.columns.find {|col| col.name.to_s == pkc.to_s }
sql_type_to_class(col.type)
end
"[#{pk_types.join(', ')}]"
end
end

private def generated_relation_methods_decl
Expand Down
Loading