FIX: PostgeSQL support in ActiveRecord #3869
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 14, 2022 07:46
… ARC (fixed support for PostgeSQL)
aleks-f
requested changes
Nov 27, 2023
| @@ -68,13 +68,13 @@ void CodeGenerator::writeHeaderComment(const std::string& fileName) const | |||
|
|
|||
| void CodeGenerator::writeInclude(const std::string& nameSpace, const std::string& name) const | |||
| { | |||
| _stream << "#include \""; | |||
| _stream << "#include <"; | |||
There was a problem hiding this comment.
Optimization of compilation process and cleanness in dependencies. <> are used for includes from external libraries and compiler shall look for included files in external includes (in MSVC Additional includes directory). "" are used for internal includes, that shall have relative path from current file. When "internally" included file is not found, a fallback to external includes is applied.
- https://learn.microsoft.com/en-us/cpp/preprocessor/hash-include-directive-c-cpp?view=msvc-170
- https://gcc.gnu.org/onlinedocs/cpp/Search-Path.html
The generator generates source code files that are externally depended to PoCo libraries.
There was a problem hiding this comment.
I'll leave this to @obiltschnig to decide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES
ActiveRecord<IDType>::lastInsertIDusespg_get_serial_sequencefor obtaining last generated ID in PostgreSQLActiveRecord<IDType>::lastInsertIDuses correct connector names for PostgeSQL and MySQLADDED
MODIFICATIONS
"externalInclude.h"-><externalInclude.h>)