Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing SharedLibrary flags to ClassLoader #4804

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow passing SharedLibrary flags to ClassLoader #4804

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
544bac1
Update ClassLoader.h
XinyuKhan Dec 2, 2024
cb384be
Merge pull request #1 from XinyuKhan/XinyuKhan-patch-1
XinyuKhan Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Foundation/include/Poco/ClassLoader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ class ClassLoader
}
}

void loadLibrary(const std::string& path, const std::string& manifest)
void loadLibrary(const std::string& path, const std::string& manifest, int flags = 0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should default to SharedLibrary::SHLIB_GLOBAL

poco/Foundation/include/Poco/SharedLibrary.h

Line 45 in d13fac6

SHLIB_GLOBAL = 1,

/// Loads a library from the given path, using the given manifest.
/// Does nothing if the library is already loaded.
/// Throws a LibraryLoadException if the library
Expand All @@ -161,7 +161,7 @@ class ClassLoader
li.refCount = 1;
try
{
li.pLibrary = new SharedLibrary(path);
li.pLibrary = new SharedLibrary(path, flags);
li.pManifest = new Manif();
std::string pocoBuildManifestSymbol("pocoBuildManifest");
pocoBuildManifestSymbol.append(manifest);
Expand Down
Loading