Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove verify_dict_indices_slice from main #20928

Merged

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Jan 27, 2025
@coastalwhite coastalwhite merged commit 176268e into pola-rs:main Jan 27, 2025
21 checks passed
@coastalwhite coastalwhite deleted the fix/remove-verify-dict-indices-slice branch January 27, 2025 08:39
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.30%. Comparing base (56fb8c4) to head (2ea8097).
Report is 60 commits behind head on main.

Files with missing lines Patch % Lines
...w/read/deserialize/dictionary_encoded/predicate.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20928      +/-   ##
==========================================
- Coverage   79.76%   79.30%   -0.46%     
==========================================
  Files        1569     1578       +9     
  Lines      222730   224109    +1379     
  Branches     2574     2574              
==========================================
+ Hits       177651   177731      +80     
- Misses      44488    45787    +1299     
  Partials      591      591              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-peters c-peters added the accepted Ready for implementation label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants