Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvement in error messages #1060

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Minor improvement in error messages #1060

merged 2 commits into from
Apr 24, 2024

Conversation

etiennebacher
Copy link
Collaborator

Fix spacing when several strings in Err_plain(). Also, I don't understand what the "Some names seen" message means and I don't think it makes the error message better so I suggest we remove it.

Old:

> pl$when(a = 1)
Error: Execution halted with the following contexts
   0: In R: in pl$when():
   0: During function call [pl$when(a = 1)]
   1: Detected a named input.This usually means that you've used `=` instead of `==`.Some names seen:a

New:

> pl$when(a = 1)
Error: Execution halted with the following contexts
   0: In R: in pl$when():
   0: During function call [pl$when(a = 1)]
   1: Detected a named input. This usually means that you've used `=` instead of `==`.

@etiennebacher etiennebacher merged commit 2988ec2 into main Apr 24, 2024
17 of 19 checks passed
@etiennebacher etiennebacher deleted the error-named-input branch April 24, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants