feat: Bump rust-polars to 0.36.2 #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitsupi
reviewed
Jan 3, 2024
| @@ -73,7 +73,7 @@ impl RPolarsDataType { | |||
| "Float32" | "float32" | "double" => pl::DataType::Float32, | |||
| "Float64" | "float64" => pl::DataType::Float64, | |||
|
|
|||
| "String" | "character" => pl::DataType::String, | |||
| "Utf8" | "String" | "character" => pl::DataType::String, | |||
There was a problem hiding this comment.
I was just getting started on this too. I think we can leave Utf8 as an alias, as py-polars does the same thing.
There was a problem hiding this comment.
Yes, we should keep an alias but I guess docs should be updated to prefer "String" instead
There was a problem hiding this comment.
Go ahead if you want, let me know when I can jump in ;)
|
I think I passed all the tests. I'm going to bed now, so I won't update any more. It would be helpful if you could update the documentation etc. |
|
@eitsupi I think it's good to go. There are no breaking changes here, so I think we could release 0.12.1 so that we don't get two rust-polars updates in one release |
eitsupi
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/pola-rs/polars/releases/tag/rs-0.36.2
We updated most things in the previous bump to unreleased 2023-12-25. The main change here is the renaming of
Utf8toString