Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:调整服务请求数图为速率指标 #249

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion web/src/polaris/monitor/serviceMonitor/overview/Page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,22 @@ import { FilterType } from '../Page'
interface Props extends DuckCmpProps<BaseInfoDuck> {
filterMap: Record<string, React.ReactNode>
}

function getButtonValue(step: React.ReactNode): string {
if (typeof step === 'string') {
return step;
} else if (React.isValidElement(step)) {
const selectElement = step as React.ReactElement;
if (React.isValidElement(selectElement.props.children)) {
const buttonElement = selectElement.props.children as React.ReactElement;
if (typeof buttonElement.props.value === 'string') {
return buttonElement.props.value;
}
}
}
return '';
}

export default function Overview(props: Props) {
const { duck, store, filterMap, dispatch } = props
const { selector, creators } = duck
Expand Down Expand Up @@ -43,7 +59,7 @@ export default function Overview(props: Props) {
<Col span={12}>
<MetricCard
{...basicQueryParam}
query={getQueryMap[MetricName.Request]({ calleeNamespace: namespace })}
query={getQueryMap[MetricName.Request]({ calleeNamespace: namespace, step: getButtonValue(filterMap[FilterType.Step]) })}
cardProps={{ bordered: true }}
cardBodyProps={{ title: '服务请求数' }}
></MetricCard>
Expand Down
1 change: 1 addition & 0 deletions web/src/polaris/monitor/serviceMonitor/service/Page.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ export default function Overview(props: Props) {
calleeService: service,
calleeMethod: interfaceName,
calleeInstance: currentInstance?.ip,
step: step,
})}
cardProps={{ bordered: true }}
cardBodyProps={{ title: '服务请求数' }}
Expand Down
36 changes: 21 additions & 15 deletions web/src/polaris/monitor/serviceMonitor/types.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import moment from 'moment'
import { getMonitorData } from '../models'
import { SumUpReduceFunction, AvgReduceFunction, MaxReduceFunction, MinReduceFunction } from '../types'
import { SumUpReduceFunction, AvgReduceFunction, MaxReduceFunction, MinReduceFunction, LatestValueReduceFunction } from '../types'

export enum MetricName {
Request = 'Request',
Expand All @@ -21,7 +21,7 @@ export const DefaultLineColors = Object.values(LineColor)

export const getQueryMap = {
[MetricName.Request]: (queryParam = {} as any) => {
const { calleeNamespace, calleeService, calleeMethod, calleeInstance } = queryParam
const { calleeNamespace, calleeService, calleeMethod, calleeInstance, step } = queryParam
const conditionSets = {
CalleeNamespace: calleeNamespace ? `callee_namespace="${calleeNamespace}"` : '',
CalleeService: calleeService ? `callee_service="${calleeService}"` : '',
Expand All @@ -32,37 +32,43 @@ export const getQueryMap = {
.filter(([, value]) => !!value)
.map(([, value]) => value)
const conditionString = conditions.join(',')
// 最小精度限制
let stepReq = step
if (stepReq < 60) {
stepReq = 60
}
return [
{
name: '总请求数',
name: '请求数',
query: conditions.length
? `sum(upstream_rq_total{${conditionString}}) or on() vector(0)`
: 'sum(upstream_rq_total) or on() vector(0)',
boardFunction: SumUpReduceFunction,
? `sum(rate(upstream_rq_total{${conditionString}}[${stepReq}s])) or on() vector(0)`
: `sum(rate(upstream_rq_total{}[${stepReq}s])) or on() vector(0)`,
boardFunction: LatestValueReduceFunction,
minStep: 60,
noLine: true,
},
{
name: '成功请求数',
query: conditions.length
? `sum(upstream_rq_total{callee_result="success",${conditionString}}) or on() vector(0)`
: 'sum(upstream_rq_total{callee_result="success"}) or on() vector(0)',
boardFunction: SumUpReduceFunction,
? `sum(rate(upstream_rq_total{callee_result="success",${conditionString}} [${stepReq}s])) or on() vector(0)`
: `sum(rate(upstream_rq_total{callee_result="success"}[${stepReq}s])) or on() vector(0)`,
boardFunction: LatestValueReduceFunction,
minStep: 60,
},
{
name: '限流请求数',
query: conditions.length
? `sum(upstream_rq_total{callee_result="flow_control",${conditionString}}) or on() vector(0)`
: 'sum(upstream_rq_total{callee_result="flow_control"}) or on() vector(0)',
boardFunction: SumUpReduceFunction,
? `sum(rate(upstream_rq_total{callee_result="flow_control",${conditionString}}[${stepReq}s])) or on() vector(0)`
: `sum(rate(upstream_rq_total{callee_result="flow_control"}[${stepReq}s])) or on() vector(0)`,
boardFunction: LatestValueReduceFunction,
minStep: 60,
},
{
name: '熔断请求数',
query: conditions.length
? `sum(upstream_rq_total{callee_result="reject",${conditionString}}) or on() vector(0)`
: 'sum(upstream_rq_total{callee_result="reject"}) or on() vector(0)',
boardFunction: SumUpReduceFunction,
? `sum(rate(upstream_rq_total{callee_result="reject",${conditionString}}[${stepReq}s])) or on() vector(0)`
: `sum(rate(upstream_rq_total{callee_result="reject"}[${stepReq}s])) or on() vector(0)`,
boardFunction: LatestValueReduceFunction,
minStep: 60,
},
]
Expand Down