Skip to content

Commit

Permalink
Update rust and use stable for benches (#574)
Browse files Browse the repository at this point in the history
<!-- Remember that you can run `/merge` to enable auto-merge in the PR
-->

<!-- Remember to modify the changelog. If you don't need to modify it,
you can check the following box.
Instead, if you have already modified it, simply delete the following
line. -->

- [x] Does not require a CHANGELOG entry

We are trying to get the command bot working. However, right now it is
timing out when trying to build the runtimes plus the omni bencher after
6 hours. This should not take 6 hours ;) So, one guess is that maybe the
nightly is doing something that takes quite long to build. We want to
try the stable compiler and see if that fixes the issue.

---------

Co-authored-by: GitHub Action <[email protected]>
  • Loading branch information
bkchr and actions-user authored Feb 14, 2025
1 parent 49cb591 commit c620a26
Show file tree
Hide file tree
Showing 18 changed files with 2,830 additions and 2,989 deletions.
4 changes: 2 additions & 2 deletions .github/env
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
RUST_STABLE_VERSION=1.81.0
RUST_NIGHTLY_VERSION=2024-09-11
RUST_STABLE_VERSION=1.84.1
RUST_NIGHTLY_VERSION=2025-01-30
TAPLO_VERSION=0.9.3
2 changes: 1 addition & 1 deletion .github/scripts/cmd/cmd.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
failed_benchmarks = {}
successful_benchmarks = {}

profile = "release"
profile = "production"

print(f'Provided runtimes: {args.runtime}')
# convert to mapped dict
Expand Down
12 changes: 10 additions & 2 deletions .github/workflows/cmd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -270,20 +270,28 @@ jobs:
ref: ${{ needs.get-pr-branch.outputs.pr-branch }}

- name: Install updates and dependencies
if: startsWith(github.event.comment.body, '/cmd bench')
if: startsWith(steps.get-pr-comment.outputs.group2, 'bench')
run: .github/install-deps.sh

- name: Set rust version via common env file
run: cat .github/env >> $GITHUB_ENV

- name: Install nightly toolchain
uses: dtolnay/rust-toolchain@master
if: startsWith(steps.get-pr-comment.outputs.group2, 'fmt') || startsWith(steps.get-pr-comment.outputs.group2, 'bench')
if: startsWith(steps.get-pr-comment.outputs.group2, 'fmt')
with:
targets: "wasm32-unknown-unknown"
components: "rust-src, rustfmt"
toolchain: "nightly-${{env.RUST_NIGHTLY_VERSION}}"

- name: Install stable toolchain
uses: dtolnay/rust-toolchain@master
if: startsWith(steps.get-pr-comment.outputs.group2, 'bench')
with:
targets: "wasm32-unknown-unknown"
components: "rust-src, rustfmt"
toolchain: "${{env.RUST_STABLE_VERSION}}"

- name: Install dependencies for bench
if: startsWith(steps.get-pr-comment.outputs.group2, 'bench')
run: cargo install subweight frame-omni-bencher --locked
Expand Down
Loading

0 comments on commit c620a26

Please sign in to comment.