Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust and use stable for benches #574

Merged
merged 11 commits into from
Feb 14, 2025
Merged

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Feb 3, 2025

  • Does not require a CHANGELOG entry

We are trying to get the command bot working. However, right now it is timing out when trying to build the runtimes plus the omni bencher after 6 hours. This should not take 6 hours ;) So, one guess is that maybe the nightly is doing something that takes quite long to build. We want to try the stable compiler and see if that fixes the issue.

@bkchr
Copy link
Contributor Author

bkchr commented Feb 3, 2025

/cmd bench --pallet pallet_balances

Copy link

github-actions bot commented Feb 3, 2025

Command "bench --pallet pallet_balances" has started 🚀 See logs here

Copy link

github-actions bot commented Feb 3, 2025

Command "bench --pallet pallet_balances" has finished ✅ See logs here

@bkchr bkchr marked this pull request as ready for review February 10, 2025 11:19
@bkchr bkchr changed the title Let's try stable Update rust and use stable for benches Feb 10, 2025
@bkontur
Copy link
Contributor

bkontur commented Feb 11, 2025

Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a --timings option on the build command, but i guess that does not help much when it already times out.
I used this reverse shell SSH stuff in the past to connect to an actions runner, it is a bit awkward but works: https://github.com/marketplace/actions/debugging-with-ssh#shut-down-server-if-user-doesnt-connect
Not sure how it interacts with self-hosted runners though 🤔

Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new rust version comes with some new helper/sugar functions that clippy wants us to use :)

@bkchr
Copy link
Contributor Author

bkchr commented Feb 11, 2025

There is also a --timings option on the build command, but i guess that does not help much when it already times out. I used this reverse shell SSH stuff in the past to connect to an actions runner, it is a bit awkward but works: https://github.com/marketplace/actions/debugging-with-ssh#shut-down-server-if-user-doesnt-connect Not sure how it interacts with self-hosted runners though 🤔

We already tried to run the commands manually on the machine and it worked.

@bkchr
Copy link
Contributor Author

bkchr commented Feb 14, 2025

/cmd fmt

Copy link

Command "fmt" has started 🚀 See logs here

Copy link

Command "fmt" has finished ✅ See logs here

@bkchr
Copy link
Contributor Author

bkchr commented Feb 14, 2025

/merge

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) February 14, 2025 09:30
@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@bkchr bkchr disabled auto-merge February 14, 2025 10:47
@bkchr bkchr enabled auto-merge (squash) February 14, 2025 10:48
@bkchr bkchr force-pushed the bkchr-try-stable-compiler branch from 461c281 to 8a00e56 Compare February 14, 2025 11:04
@bkchr bkchr merged commit c620a26 into main Feb 14, 2025
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants