Treasury Spend Params Issue #11265
Merged
Treasury Spend Params Issue #11265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Feb 5, 2025
TarikGul
approved these changes
Feb 5, 2025
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR aims to fix params for treasury
spendmethod -🧐 Previous Behavior
Earlier, When creating a preimage for a
treasury.spendcall, the GeneralIndex and Amount (AssetBalanceOf) fields are shown in DOT on Polkadot-JS UI, which can be confusing for proposal submitters.✅ Current Behavior
treasury.spend, if proposal is for 100 USDT thenGeneralIndexshould be provided as 1984 andamountshould be100000000(plancks unit)Also, It fixes the bugs shown in this doc
treasury.spendLocal, it will not expect amount in planck units. For example, If proposal is for 10.05 DOT, simply put 10.05 not 100500000000. It will be automatically compiled in planck units.