Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set pomerium core version #857

Merged
merged 2 commits into from
Jan 6, 2024
Merged

ci: set pomerium core version #857

merged 2 commits into from
Jan 6, 2024

Conversation

wasaga
Copy link
Collaborator

@wasaga wasaga commented Jan 5, 2024

Summary

Previously, we did not set corresponding Pomerium Core version, that caused it to be rendered as
v0.0.0 in other applications when built as Ingress Controller.

Related issues

Fixes #855

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@wasaga wasaga requested a review from a team as a code owner January 5, 2024 20:02
@wasaga wasaga requested review from kenjenkins and calebdoxsey and removed request for a team January 5, 2024 20:02
@wasaga wasaga requested a review from kenjenkins January 5, 2024 21:24
@wasaga wasaga merged commit db034ef into main Jan 6, 2024
6 checks passed
@wasaga wasaga deleted the wasaga/fix-build-version branch January 6, 2024 03:04
@wasaga wasaga added dependencies Pull requests that update a dependency file ignore-changelog do not display in the changelog labels Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ignore-changelog do not display in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: pomerium version should match the pomerium/pomerium dependency
2 participants