Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for the categorizer form #152

Merged
merged 9 commits into from
Dec 24, 2021
Merged

add tests for the categorizer form #152

merged 9 commits into from
Dec 24, 2021

Conversation

ZhongweiL
Copy link
Contributor

@ZhongweiL ZhongweiL commented Dec 3, 2021 •
edited
Loading

Follow up on PR #148 and resolve #147

@khatchad
Copy link
Member

khatchad commented Dec 3, 2021

@ZhongweiL Please work on fixing your last tests before you add new ones. Thanks.

khatchad
khatchad requested changes Dec 3, 2021
View reviewed changes
Copy link
Member

@khatchad khatchad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more tests about using empty data. For example, try to submit a form that's missing a name, initials, or Django user. Basically, three more tests.

ponder/tests.py Show resolved Hide resolved
ponder/tests.py Show resolved Hide resolved
@khatchad
Copy link
Member

khatchad commented Dec 7, 2021

@ZhongweiL Please split these PRs such that:

  1. We have the fix for the existing tests.
  2. We have the new tests.

khatchad
khatchad requested changes Dec 7, 2021
View reviewed changes
ponder/tests.py Show resolved Hide resolved
ponder/tests.py Outdated Show resolved Hide resolved
@khatchad
Copy link
Member

This PR is failing, thus we can't merge it.

@ZhongweiL
Copy link
Contributor Author

@khatchad Can this now be merged?

@ZhongweiL ZhongweiL requested a review from khatchad December 23, 2021 23:58
@khatchad
Copy link
Member

Go for it.

@ZhongweiL ZhongweiL merged commit 5a7c0a6 into ponder-lab:main Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khatchad khatchad Awaiting requested review from khatchad

Assignees

@ZhongweiL ZhongweiL

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Categorizers are missing a foreign key into Django users
2 participants
@ZhongweiL @khatchad