Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enabling and fixing django ci tests #189

Merged
merged 9 commits into from
Jan 29, 2025
Merged

Conversation

y3pio
Copy link
Collaborator

@y3pio y3pio commented Jan 25, 2025

PR Summary

Re-enabling pipeline steps.

Details

Testing/QA

  • N/A

@y3pio y3pio requested a review from khatchad January 25, 2025 00:36
@y3pio
Copy link
Collaborator Author

y3pio commented Jan 25, 2025

@khatchad Looks like the CICD step to run these tests is expecting to create a DB for testing:

Creating test database for alias 'default'...
Got an error creating the test database: (1044, "Access denied for user 'dace[5](https://github.com/ponder-lab/Imperative-DL-Study-Web-App/actions/runs/12959931686/job/36153020001?pr=189#step:5:5)c60l5ctt7og'@'%' to database 'test_uoq6lb032iusvpqz'")

Not sure if our current free setup with JawsDB allows for DB creation. I tried logging into the DB manually to try and create a DB and I'm running into the same permissions error above. -- Will keep digging into an alternate solution for these tests.

@y3pio y3pio changed the title re-enabling django cicd pipeline steps re-enabling and fixing django ci tests Jan 27, 2025
@y3pio y3pio added the bug Something isn't working label Jan 27, 2025
@y3pio
Copy link
Collaborator Author

y3pio commented Jan 28, 2025

Added test/tests_model.py to test the core model features for some of our models that have business logic. I think this should suffice for now as a possibly temp solution for CI testing without a DB that we can create tables with.

Moved the old tests into OLD_test.py to re-enable at a future date once we have access to a DB with table creation privileges.

Also created #190 to track efforts to create unit tests for views.

@y3pio y3pio merged commit ee0d682 into main Jan 29, 2025
1 check passed
@y3pio y3pio deleted the ypaing/reenable-cicd-steps branch January 31, 2025 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant