Fix missing callbacks #57

tatianacv · 2023-11-29T05:33:32Z

tatianacv · 2023-11-29T05:36:19Z

For the first test tf2_test_callbacks.py, the CG is:

Node: synthetic < PythonLoader, Lcom/ibm/wala/FakeRootClass, fakeRootMethod()V > Context: Everywhere
 - invokestatic < PythonLoader, Lcom/ibm/wala/FakeRootClass, fakeWorldClinit()V >@0
     -> Node: synthetic < PythonLoader, Lcom/ibm/wala/FakeRootClass, fakeWorldClinit()V > Context: Everywhere
 - invokevirtual < PythonLoader, Lscript tf2_test_callbacks.py, do()LRoot; >@2
     -> Node: <Code body of function Lscript tf2_test_callbacks.py> Context: CallStringContext: [ com.ibm.wala.FakeRootClass.fakeRootMethod()V@2 ]

Node: synthetic < PythonLoader, Lcom/ibm/wala/FakeRootClass, fakeWorldClinit()V > Context: Everywhere

Node: <Code body of function Lscript tf2_test_callbacks.py> Context: CallStringContext: [ com.ibm.wala.FakeRootClass.fakeRootMethod()V@2 ]
 - invokestatic < PythonLoader, Ltensorflow, import()Ltensorflow; >@90
     -> Node: synthetic < PythonLoader, Ltensorflow, import()Ltensorflow; > Context: CallStringContext: [ script tf2_test_callbacks.py.do()LRoot;@90 ]
 - JSCall@104
     -> Node: synthetic < PythonLoader, Ltensorflow/distribute/MirroredStrategy, do()LRoot; > Context: CallStringContext: [ script tf2_test_callbacks.py.do()LRoot;@104 ]
 - JSCall@111
     -> Node: synthetic < PythonLoader, Ltensorflow/distribute/distribute_datasets_from_function/distribute_datasets_from_function, do()LRoot; > Context: CallStringContext: [ script tf2_test_callbacks.py.do()LRoot;@111 ]

Node: synthetic < PythonLoader, Ltensorflow, import()Ltensorflow; > Context: CallStringContext: [ script tf2_test_callbacks.py.do()LRoot;@90 ]

Node: synthetic < PythonLoader, Ltensorflow/distribute/MirroredStrategy, do()LRoot; > Context: CallStringContext: [ script tf2_test_callbacks.py.do()LRoot;@104 ]

Node: synthetic < PythonLoader, Ltensorflow/distribute/distribute_datasets_from_function/distribute_datasets_from_function, do()LRoot; > Context: CallStringContext: [ script tf2_test_callbacks.py.do()LRoot;@111 ]

For the second test tf2_test_callbacks2.py, the CG is:

Node: synthetic < PythonLoader, Lcom/ibm/wala/FakeRootClass, fakeRootMethod()V > Context: Everywhere
 - invokestatic < PythonLoader, Lcom/ibm/wala/FakeRootClass, fakeWorldClinit()V >@0
     -> Node: synthetic < PythonLoader, Lcom/ibm/wala/FakeRootClass, fakeWorldClinit()V > Context: Everywhere
 - invokevirtual < PythonLoader, Lscript tf2_test_callbacks2.py, do()LRoot; >@2
     -> Node: <Code body of function Lscript tf2_test_callbacks2.py> Context: CallStringContext: [ com.ibm.wala.FakeRootClass.fakeRootMethod()V@2 ]

Node: synthetic < PythonLoader, Lcom/ibm/wala/FakeRootClass, fakeWorldClinit()V > Context: Everywhere

Node: <Code body of function Lscript tf2_test_callbacks2.py> Context: CallStringContext: [ com.ibm.wala.FakeRootClass.fakeRootMethod()V@2 ]
 - invokestatic < PythonLoader, Ltensorflow, import()Ltensorflow; >@90
     -> Node: synthetic < PythonLoader, Ltensorflow, import()Ltensorflow; > Context: CallStringContext: [ script tf2_test_callbacks2.py.do()LRoot;@90 ]
 - JSCall@96
     -> Node: synthetic < PythonLoader, Ltensorflow/distribute/MirroredStrategy, do()LRoot; > Context: CallStringContext: [ script tf2_test_callbacks2.py.do()LRoot;@96 ]
 - JSCall@99
     -> Node: synthetic < PythonLoader, Ltensorflow/functions/constant, do()LRoot; > Context: CallStringContext: [ script tf2_test_callbacks2.py.do()LRoot;@99 ]
 - JSCall@108
     -> Node: synthetic < PythonLoader, Ltensorflow/distribute/run/run, do()LRoot; > Context: CallStringContext: [ script tf2_test_callbacks2.py.do()LRoot;@108 ]

Node: synthetic < PythonLoader, Ltensorflow, import()Ltensorflow; > Context: CallStringContext: [ script tf2_test_callbacks2.py.do()LRoot;@90 ]

Node: synthetic < PythonLoader, Ltensorflow/functions/constant, do()LRoot; > Context: CallStringContext: [ script tf2_test_callbacks2.py.do()LRoot;@99 ]
 - invokevirtual < PythonLoader, LRoot, read_data()LRoot; >@0
     -> Node: synthetic < PythonLoader, Ltensorflow/functions/constant, read_data()LRoot; > Context: CallStringContext: [ tensorflow.functions.constant.do()LRoot;@0 ]

Node: synthetic < PythonLoader, Ltensorflow/functions/constant, read_data()LRoot; > Context: CallStringContext: [ tensorflow.functions.constant.do()LRoot;@0 ]

Node: synthetic < PythonLoader, Ltensorflow/distribute/MirroredStrategy, do()LRoot; > Context: CallStringContext: [ script tf2_test_callbacks2.py.do()LRoot;@96 ]

Node: synthetic < PythonLoader, Ltensorflow/distribute/run/run, do()LRoot; > Context: CallStringContext: [ script tf2_test_callbacks2.py.do()LRoot;@108 ]

tatianacv · 2023-11-29T05:37:17Z

As we can see from the CGs, the functions being called are not showing up in the CG. Only the APIs that are being used.

tatianacv · 2023-11-29T05:38:30Z

I ran an example on the TF Estimator referenced in the issue (wala#92 (comment)), and the CG is similar to what we see here.

com.ibm.wala.cast.python.test/data/tf2_test_callbacks.py

com.ibm.wala.cast.python.test/data/tf2_test_callbacks2.py

...bm.wala.cast.python.ml.test/source/com/ibm/wala/cast/python/ml/test/TestTensorflowModel.java

tatianacv · 2023-11-30T02:47:35Z

The CG for the first test:

Node: synthetic < PythonLoader, Lcom/ibm/wala/FakeRootClass, fakeRootMethod()V > Context: Everywhere
 - invokestatic < PythonLoader, Lcom/ibm/wala/FakeRootClass, fakeWorldClinit()V >@0
     -> Node: synthetic < PythonLoader, Lcom/ibm/wala/FakeRootClass, fakeWorldClinit()V > Context: Everywhere
 - invokevirtual < PythonLoader, Lscript tf2_test_callbacks.py, do()LRoot; >@2
     -> Node: <Code body of function Lscript tf2_test_callbacks.py> Context: CallStringContext: [ com.ibm.wala.FakeRootClass.fakeRootMethod()V@2 ]

Node: synthetic < PythonLoader, Lcom/ibm/wala/FakeRootClass, fakeWorldClinit()V > Context: Everywhere

Node: <Code body of function Lscript tf2_test_callbacks.py> Context: CallStringContext: [ com.ibm.wala.FakeRootClass.fakeRootMethod()V@2 ]
 - invokestatic < PythonLoader, Ltensorflow, import()Ltensorflow; >@90
     -> Node: synthetic < PythonLoader, Ltensorflow, import()Ltensorflow; > Context: CallStringContext: [ script tf2_test_callbacks.py.do()LRoot;@90 ]
 - JSCall@104
     -> Node: synthetic < PythonLoader, Ltensorflow/distribute/MirroredStrategy, do()LRoot; > Context: CallStringContext: [ script tf2_test_callbacks.py.do()LRoot;@104 ]
 - JSCall@111
     -> Node: synthetic < PythonLoader, Ltensorflow/distribute/distribute_datasets_from_function/distribute_datasets_from_function, do()LRoot; > Context: CallStringContext: [ script tf2_test_callbacks.py.do()LRoot;@111 ]

Node: synthetic < PythonLoader, Ltensorflow, import()Ltensorflow; > Context: CallStringContext: [ script tf2_test_callbacks.py.do()LRoot;@90 ]

Node: synthetic < PythonLoader, Ltensorflow/distribute/MirroredStrategy, do()LRoot; > Context: CallStringContext: [ script tf2_test_callbacks.py.do()LRoot;@104 ]

Node: synthetic < PythonLoader, Ltensorflow/distribute/distribute_datasets_from_function/distribute_datasets_from_function, do()LRoot; > Context: CallStringContext: [ script tf2_test_callbacks.py.do()LRoot;@111 ]
 - invokevirtual < PythonLoader, LRoot, do()LRoot; >@3
     -> Node: <Code body of function Lscript tf2_test_callbacks.py/get_dataset> Context: CallStringContext: [ tensorflow.distribute.distribute_datasets_from_function.distribute_datasets_from_function.do()LRoot;@3 ]

Node: <Code body of function Lscript tf2_test_callbacks.py/get_dataset> Context: CallStringContext: [ tensorflow.distribute.distribute_datasets_from_function.distribute_datasets_from_function.do()LRoot;@3 ]

tatianacv · 2023-11-30T02:48:19Z

The CG for the second test:

[FINE] Call graph:
Node: synthetic < PythonLoader, Lcom/ibm/wala/FakeRootClass, fakeRootMethod()V > Context: Everywhere
 - invokestatic < PythonLoader, Lcom/ibm/wala/FakeRootClass, fakeWorldClinit()V >@0
     -> Node: synthetic < PythonLoader, Lcom/ibm/wala/FakeRootClass, fakeWorldClinit()V > Context: Everywhere
 - invokevirtual < PythonLoader, Lscript tf2_test_callbacks2.py, do()LRoot; >@2
     -> Node: <Code body of function Lscript tf2_test_callbacks2.py> Context: CallStringContext: [ com.ibm.wala.FakeRootClass.fakeRootMethod()V@2 ]

Node: synthetic < PythonLoader, Lcom/ibm/wala/FakeRootClass, fakeWorldClinit()V > Context: Everywhere

Node: <Code body of function Lscript tf2_test_callbacks2.py> Context: CallStringContext: [ com.ibm.wala.FakeRootClass.fakeRootMethod()V@2 ]
 - invokestatic < PythonLoader, Ltensorflow, import()Ltensorflow; >@90
     -> Node: synthetic < PythonLoader, Ltensorflow, import()Ltensorflow; > Context: CallStringContext: [ script tf2_test_callbacks2.py.do()LRoot;@90 ]
 - JSCall@96
     -> Node: synthetic < PythonLoader, Ltensorflow/distribute/MirroredStrategy, do()LRoot; > Context: CallStringContext: [ script tf2_test_callbacks2.py.do()LRoot;@96 ]
 - JSCall@99
     -> Node: synthetic < PythonLoader, Ltensorflow/functions/constant, do()LRoot; > Context: CallStringContext: [ script tf2_test_callbacks2.py.do()LRoot;@99 ]
 - JSCall@108
     -> Node: synthetic < PythonLoader, Ltensorflow/distribute/run/run, do()LRoot; > Context: CallStringContext: [ script tf2_test_callbacks2.py.do()LRoot;@108 ]

Node: synthetic < PythonLoader, Ltensorflow, import()Ltensorflow; > Context: CallStringContext: [ script tf2_test_callbacks2.py.do()LRoot;@90 ]

Node: synthetic < PythonLoader, Ltensorflow/functions/constant, do()LRoot; > Context: CallStringContext: [ script tf2_test_callbacks2.py.do()LRoot;@99 ]
 - invokevirtual < PythonLoader, LRoot, read_data()LRoot; >@0
     -> Node: synthetic < PythonLoader, Ltensorflow/functions/constant, read_data()LRoot; > Context: CallStringContext: [ tensorflow.functions.constant.do()LRoot;@0 ]

Node: synthetic < PythonLoader, Ltensorflow/functions/constant, read_data()LRoot; > Context: CallStringContext: [ tensorflow.functions.constant.do()LRoot;@0 ]

Node: synthetic < PythonLoader, Ltensorflow/distribute/MirroredStrategy, do()LRoot; > Context: CallStringContext: [ script tf2_test_callbacks2.py.do()LRoot;@96 ]

Node: synthetic < PythonLoader, Ltensorflow/distribute/run/run, do()LRoot; > Context: CallStringContext: [ script tf2_test_callbacks2.py.do()LRoot;@108 ]
 - invokevirtual < PythonLoader, LRoot, do()LRoot; >@3
     -> Node: <Code body of function Lscript tf2_test_callbacks2.py/replica_fn> Context: CallStringContext: [ tensorflow.distribute.run.run.do()LRoot;@3 ]

Node: <Code body of function Lscript tf2_test_callbacks2.py/replica_fn> Context: CallStringContext: [ tensorflow.distribute.run.run.do()LRoot;@3 ]

com.ibm.wala.cast.python.test/data/tf2_test_callbacks.py

khatchad · 2023-11-30T15:02:39Z

BTW, these are examples of ones that are missing. Are there more that we need that are obvious?

...bm.wala.cast.python.ml.test/source/com/ibm/wala/cast/python/ml/test/TestTensorflowModel.java

tatianacv · 2023-11-30T17:26:58Z

BTW, these are examples of ones that are missing. Are there more that we need that are obvious?

Actually it is MirrorStrategy or TPUStrategy. This is where they are initializing strategy with method create_distribute_strategy
(https://github.com/mead-ml/mead-baseline/blob/5d7632bb151c2d09501ebf49f36ba8c4204df4c8/mead/api_examples/pretrain_discrim_tf.py#L278) and that method create_distribute_strategy uses MirrorStrategy or TPUStrategy
https://github.com/mead-ml/mead-baseline/blob/5d7632bb151c2d09501ebf49f36ba8c4204df4c8/layers/eight_mile/tf/layers.py#L121

khatchad · 2023-11-30T20:25:50Z

The CG for the first test:

Node: synthetic < PythonLoader, Lcom/ibm/wala/FakeRootClass, fakeRootMethod()V > Context: Everywhere
 - invokestatic < PythonLoader, Lcom/ibm/wala/FakeRootClass, fakeWorldClinit()V >@0
     -> Node: synthetic < PythonLoader, Lcom/ibm/wala/FakeRootClass, fakeWorldClinit()V > Context: Everywhere
 - invokevirtual < PythonLoader, Lscript tf2_test_callbacks.py, do()LRoot; >@2
     -> Node: <Code body of function Lscript tf2_test_callbacks.py> Context: CallStringContext: [ com.ibm.wala.FakeRootClass.fakeRootMethod()V@2 ]

Node: synthetic < PythonLoader, Lcom/ibm/wala/FakeRootClass, fakeWorldClinit()V > Context: Everywhere

Node: <Code body of function Lscript tf2_test_callbacks.py> Context: CallStringContext: [ com.ibm.wala.FakeRootClass.fakeRootMethod()V@2 ]
 - invokestatic < PythonLoader, Ltensorflow, import()Ltensorflow; >@90
     -> Node: synthetic < PythonLoader, Ltensorflow, import()Ltensorflow; > Context: CallStringContext: [ script tf2_test_callbacks.py.do()LRoot;@90 ]
 - JSCall@104
     -> Node: synthetic < PythonLoader, Ltensorflow/distribute/MirroredStrategy, do()LRoot; > Context: CallStringContext: [ script tf2_test_callbacks.py.do()LRoot;@104 ]
 - JSCall@111
     -> Node: synthetic < PythonLoader, Ltensorflow/distribute/distribute_datasets_from_function/distribute_datasets_from_function, do()LRoot; > Context: CallStringContext: [ script tf2_test_callbacks.py.do()LRoot;@111 ]

Node: synthetic < PythonLoader, Ltensorflow, import()Ltensorflow; > Context: CallStringContext: [ script tf2_test_callbacks.py.do()LRoot;@90 ]

Node: synthetic < PythonLoader, Ltensorflow/distribute/MirroredStrategy, do()LRoot; > Context: CallStringContext: [ script tf2_test_callbacks.py.do()LRoot;@104 ]

Node: synthetic < PythonLoader, Ltensorflow/distribute/distribute_datasets_from_function/distribute_datasets_from_function, do()LRoot; > Context: CallStringContext: [ script tf2_test_callbacks.py.do()LRoot;@111 ]
 - invokevirtual < PythonLoader, LRoot, do()LRoot; >@3
     -> Node: <Code body of function Lscript tf2_test_callbacks.py/get_dataset> Context: CallStringContext: [ tensorflow.distribute.distribute_datasets_from_function.distribute_datasets_from_function.do()LRoot;@3 ]

Node: <Code body of function Lscript tf2_test_callbacks.py/get_dataset> Context: CallStringContext: [ tensorflow.distribute.distribute_datasets_from_function.distribute_datasets_from_function.do()LRoot;@3 ]

Could we have the diffs of these?

khatchad · 2023-11-30T20:29:48Z

Here's the diff of your CGs after some editing:

29a30,33
>  - invokevirtual < PythonLoader, LRoot, do()LRoot; >@3
>      -> Node: <Code body of function Lscript tf2_test_callbacks2.py/replica_fn> Context: CallStringContext: [ tensorflow.distribute.run.run.do()LRoot;@3 ]
> 
> Node: <Code body of function Lscript tf2_test_callbacks2.py/replica_fn> Context: CallStringContext: [ tensorflow.distribute.run.run.do()LRoot;@3 ]

This is certainly promising, but the tensor analysis still isn't picking up the tensor parameters. My guess is that the argument (in the second test; I'm not looking at the first) isn't being connected to the parameter in the XML.

khatchad · 2023-11-30T20:30:22Z

It would also be helpful to see the IR and pointer analyses.

khatchad · 2023-11-30T20:32:16Z

It may also be helpful to have a function that isn't a call back in the example and that directly takes a tensor parameter.

I will also say that if you simply return tf.constant() in the first test from the callback, you may seem some results. I would remove the parameter, especially since it looks like it's unused.

khatchad

Tensor parameters don't look right.

...bm.wala.cast.python.ml.test/source/com/ibm/wala/cast/python/ml/test/TestTensorflowModel.java

com.ibm.wala.cast.python.ml/data/tensorflow.xml

khatchad · 2023-11-30T20:45:53Z

com.ibm.wala.cast.python.ml/data/tensorflow.xml

+
+    <package name="tensorflow/distribute/run">
+      <class name="run" allocatable="true">
+        <method name="do" descriptor="()LRoot;" numArgs="2" paramNames="self fn">


Looking at https://www.tensorflow.org/api_docs/python/tf/distribute/Strategy#run, run() takes also args=(). Looks like that needs to be passed to the callback.

com.ibm.wala.cast.python.test/data/tf2_test_callbacks.py

...bm.wala.cast.python.ml.test/source/com/ibm/wala/cast/python/ml/test/TestTensorflowModel.java

Only having it in the CG is not going to help us.

I don't think we need both.

One direct and one indirect.

We know this now as a result of wala#109.

com.ibm.wala.cast.python.ml/data/tensorflow.xml

khatchad · 2023-12-01T20:27:02Z

This is really an interesting case with the Strategy.run(). The given callback can take a tuple of tensors, but Strategy.run() will send a single tensor to the callback.

khatchad · 2023-12-01T20:30:10Z

This is really an interesting case with the Strategy.run(). The given callback can take a tuple of tensors, but Strategy.run() will send a single tensor to the callback.

(Quoting my own message here) I don't know if that's possible to say in the XML summary. We may need some Java code to unpack that.

khatchad · 2023-12-01T20:45:17Z

com.ibm.wala.cast.python.ml/data/tensorflow.xml

+          <new def="x" class="Lobject" />
+          <putfield class="LRoot" field="MirroredStrategy" fieldType="LRoot" ref="self" value="x" />
+          <putfield class="LRoot" field="$callback" fieldType="LRoot" ref="x" value="fn" />
+          <call class="LRoot" name="do" descriptor="()LRoot;" type="virtual" arg0="fn" arg1="1" numArgs="2" def="xx" />


Why does arg1 take 1 here?

com.ibm.wala.cast.python.ml/data/tensorflow.xml

khatchad · 2023-12-01T21:28:07Z

com.ibm.wala.cast.python.ml/data/tensorflow.xml

@@ -786,6 +792,58 @@
      </class>
    </package>

+    <package name="tensorflow/distribute">
+      <class name="MirroredStrategy" allocatable="true">
+        <method name="do" descriptor="()LRoot;" numArgs="3" paramNames="self function">


Why are there three arguments but only two parameter names?

khatchad · 2023-12-01T21:44:32Z

OK. I think I made some kind of progress here. I'm seeing:

[Node: <Code body of function Lscript tf2_test_callbacks2.py/replica_fn> Context: CallStringContext: [ tensorflow.distribute.run.run.do()LRoot;@4 ], v2] --> [SITE_IN_NODE{<Code body of function Lscript tf2_test_callbacks2.py>:Ltuple in CallStringContext: [ com.ibm.wala.FakeRootClass.fakeRootMethod()V@2 ]}]

So, it's a tuple of tensors being sent to replica_fn, which is progress but not quite what we want.

@tatianacv Can you verify we don't have this in the PA without my latest changes?

khatchad · 2023-12-04T22:20:48Z

Superseded by #61.

Adding the APIs

440e641

khatchad requested changes Nov 29, 2023

View reviewed changes

khatchad changed the title ~~Missing Callbacks~~ Fix missing callbacks Nov 29, 2023

tatianacv added 4 commits November 29, 2023 16:40

Adding other test

a8e2ddc

Adding documentation

ebc3b34

Getting the callbacks in the CG

ae7078c

Adding spotless

db9f985

Adding experimental

7b6717b

tatianacv marked this pull request as ready for review November 30, 2023 02:57

khatchad requested changes Nov 30, 2023

View reviewed changes

com.ibm.wala.cast.python.test/data/tf2_test_callbacks.py Outdated Show resolved Hide resolved

khatchad reviewed Nov 30, 2023

View reviewed changes

...bm.wala.cast.python.ml.test/source/com/ibm/wala/cast/python/ml/test/TestTensorflowModel.java Outdated Show resolved Hide resolved

khatchad requested changes Nov 30, 2023

View reviewed changes

...bm.wala.cast.python.ml.test/source/com/ibm/wala/cast/python/ml/test/TestTensorflowModel.java Outdated Show resolved Hide resolved

tatianacv and others added 2 commits November 30, 2023 12:35

Addressing requested changes

7131070

Merge branch 'master' into 92-missing_callbacks

72610a6

khatchad requested changes Nov 30, 2023

View reviewed changes

...bm.wala.cast.python.ml.test/source/com/ibm/wala/cast/python/ml/test/TestTensorflowModel.java Outdated Show resolved Hide resolved

...bm.wala.cast.python.ml.test/source/com/ibm/wala/cast/python/ml/test/TestTensorflowModel.java Outdated Show resolved Hide resolved

tatianacv marked this pull request as draft November 30, 2023 20:42

khatchad requested changes Nov 30, 2023

View reviewed changes

khatchad reviewed Nov 30, 2023

View reviewed changes

com.ibm.wala.cast.python.test/data/tf2_test_callbacks.py Outdated Show resolved Hide resolved

Add correct params, but test will fail

5e29516

khatchad reviewed Nov 30, 2023

View reviewed changes

...bm.wala.cast.python.ml.test/source/com/ibm/wala/cast/python/ml/test/TestTensorflowModel.java Outdated Show resolved Hide resolved

khatchad added 8 commits November 30, 2023 16:48

Let's focus on one test for now.

95df2eb

Remove comment.

3ec179a

Only having it in the CG is not going to help us.

Lose a URL.

e5d5a3a

I don't think we need both.

Format.

6b0af76

Change tests.

6bcb8ae

One direct and one indirect.

Merge branch 'master' into 92-missing_callbacks

761b231

The value number here is actually 2 not 1.

b0c13ec

We know this now as a result of wala#109.

Also update the comment.

873c7f0

khatchad reviewed Dec 1, 2023

View reviewed changes

com.ibm.wala.cast.python.ml/data/tensorflow.xml Show resolved Hide resolved

khatchad reviewed Dec 1, 2023

View reviewed changes

com.ibm.wala.cast.python.ml/data/tensorflow.xml Show resolved Hide resolved

khatchad reviewed Dec 1, 2023

View reviewed changes

khatchad added 2 commits December 1, 2023 16:37

Took a crack at sending the argument.

82969d6

Yet another crack.

835548c

khatchad self-assigned this Dec 3, 2023

khatchad added the bug Something isn't working label Dec 3, 2023

khatchad closed this Dec 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix missing callbacks #57

Fix missing callbacks #57

tatianacv commented Nov 29, 2023 •

edited by khatchad

Loading

tatianacv commented Nov 29, 2023

tatianacv commented Nov 29, 2023

tatianacv commented Nov 29, 2023

tatianacv commented Nov 30, 2023

tatianacv commented Nov 30, 2023

khatchad commented Nov 30, 2023

tatianacv commented Nov 30, 2023

khatchad commented Nov 30, 2023

khatchad commented Nov 30, 2023

khatchad commented Nov 30, 2023

khatchad commented Nov 30, 2023

khatchad left a comment

khatchad Nov 30, 2023

khatchad commented Dec 1, 2023

khatchad commented Dec 1, 2023

khatchad Dec 1, 2023

khatchad Dec 1, 2023

khatchad commented Dec 1, 2023

khatchad commented Dec 4, 2023

Fix missing callbacks #57

Fix missing callbacks #57

Conversation

tatianacv commented Nov 29, 2023 • edited by khatchad Loading

tatianacv commented Nov 29, 2023

tatianacv commented Nov 29, 2023

tatianacv commented Nov 29, 2023

tatianacv commented Nov 30, 2023

tatianacv commented Nov 30, 2023

khatchad commented Nov 30, 2023

tatianacv commented Nov 30, 2023

khatchad commented Nov 30, 2023

khatchad commented Nov 30, 2023

khatchad commented Nov 30, 2023

khatchad commented Nov 30, 2023

khatchad left a comment

Choose a reason for hiding this comment

khatchad Nov 30, 2023

Choose a reason for hiding this comment

khatchad commented Dec 1, 2023

khatchad commented Dec 1, 2023

khatchad Dec 1, 2023

Choose a reason for hiding this comment

khatchad Dec 1, 2023

Choose a reason for hiding this comment

khatchad commented Dec 1, 2023

khatchad commented Dec 4, 2023

tatianacv commented Nov 29, 2023 •

edited by khatchad

Loading