Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Feat/pop 34 convert error code #12

Merged
merged 8 commits into from
Mar 12, 2024
Merged

Conversation

C4N4242
Copy link
Contributor

@C4N4242 C4N4242 commented Dec 21, 2023

issue POP-34 on Linear

Copy link

linear bot commented Dec 21, 2023

src/entry/adaptor/errors.ts Outdated Show resolved Hide resolved
Co-authored-by: Tatsuto YAMAMOTO <[email protected]>
@C4N4242 C4N4242 self-assigned this Mar 11, 2024
Copy link
Member

@laminne laminne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errToCodeがmain.tsで使われていない状態なので、エラーを返す部分で呼び出すようにしてください

@C4N4242 C4N4242 marked this pull request as ready for review March 12, 2024 10:50
@C4N4242
Copy link
Contributor Author

C4N4242 commented Mar 12, 2024

errToCodeがmain.tsで使われていない状態なので、エラーを返す部分で呼び出すようにしてください

修正しました

tsconfig.json Outdated Show resolved Hide resolved
src/entry/main.ts Outdated Show resolved Hide resolved
@laminne laminne merged commit 8d5511a into main Mar 12, 2024
3 checks passed
@laminne laminne deleted the feat/pop-34-convert-errorCode branch March 12, 2024 14:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants