Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(api,service): 本戦試合生成をトーナメント方式に変更 #861

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

laminne
Copy link
Member

@laminne laminne commented Jan 7, 2025

close #618

やったこと

  • 試合生成方式を2チーム手動設定からnチーム(configで設定する)トーナメントに変更
  • それに伴うコードの修正

できていないこと/できなかったこと

  • (このPRで対応) 試合番号を正しく生成する
    • 現在は全て1-1として生成
  • (このPRで対応) 部門を選択できるようにする
  • (このPRでは対応しない) 人数が2冪の値でないときの穴埋め処理

破壊的変更

手動本戦試合生成エンドポイントのスキーマを変更.

{
-  teamID1: string,
-  teamID2: string
+  teamIDs: string[]
}

※ teamIDs: 予選までの順位でソートされているものとみなして処理します。

@laminne laminne added help wanted Extra attention is needed backend Related to kcmsx/kcms 改善 labels Jan 7, 2025
@laminne laminne requested review from kiharu3112 and tufusa January 7, 2025 12:15
@laminne laminne self-assigned this Jan 7, 2025
Copy link

cloudflare-workers-and-pages bot commented Jan 7, 2025

Deploying kcmsx with  Cloudflare Pages  Cloudflare Pages

Latest commit: 54467a4
Status: ✅  Deploy successful!
Preview URL: https://abcba915.kcmsx.pages.dev
Branch Preview URL: https://feat-618-tournament.kcmsx.pages.dev

View logs

@laminne laminne marked this pull request as ready for review January 7, 2025 13:15
@laminne laminne enabled auto-merge (squash) January 7, 2025 13:15
@laminne laminne force-pushed the feat/618-tournament branch from 1f3126d to a7ab7ff Compare January 10, 2025 00:21
Copy link
Member

@tufusa tufusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

読めたところまで

packages/kcms/src/match/service/generateMain.test.ts Outdated Show resolved Hide resolved
packages/kcms/src/match/service/generateMain.test.ts Outdated Show resolved Hide resolved
packages/kcms/src/match/service/generateMain.ts Outdated Show resolved Hide resolved
packages/kcms/src/match/service/generateMain.ts Outdated Show resolved Hide resolved
packages/kcms/src/match/service/generateMain.ts Outdated Show resolved Hide resolved
packages/kcms/src/match/service/generateMain.ts Outdated Show resolved Hide resolved
packages/kcms/src/match/service/generateMain.ts Outdated Show resolved Hide resolved
packages/kcms/src/match/service/generateMain.ts Outdated Show resolved Hide resolved
packages/kcms/src/match/service/generateMain.ts Outdated Show resolved Hide resolved
packages/kcms/src/match/service/generateMain.ts Outdated Show resolved Hide resolved
@laminne laminne requested a review from tufusa January 10, 2025 03:47
Copy link
Member

@tufusa tufusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

読めたところまで

packages/kcms/src/match/service/generateMain.ts Outdated Show resolved Hide resolved
packages/kcms/src/match/service/generateMain.ts Outdated Show resolved Hide resolved
packages/kcms/src/match/service/generateMain.ts Outdated Show resolved Hide resolved
packages/kcms/src/match/service/generateMain.ts Outdated Show resolved Hide resolved
packages/kcms/src/match/service/generateMain.ts Outdated Show resolved Hide resolved
packages/kcms/src/match/service/generateMain.ts Outdated Show resolved Hide resolved
packages/kcms/src/match/service/generateMain.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to kcmsx/kcms help wanted Extra attention is needed 改善
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

feat: 本戦トーナメントを生成できるようにする
2 participants