Vaquita QC #1538
Merged
Vaquita QC #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrelharp
approved these changes
Oct 25, 2023
|
Oh this is because of #1537. Hm, let's see. |
|
@andrewkern do you know how to clear |
petrelharp
force-pushed
the
vaquita_qc
branch
from
ad09d37 to
314482f
Compare
|
Ah I think we just needed a rebase |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1538 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 129 130 +1
Lines 4307 4319 +12
Branches 594 594
=======================================
+ Hits 4301 4313 +12
Misses 3 3
Partials 3 3
☔ View full report in Codecov by Sentry. |
|
This looks good to me, shall we merge, @ckyriazis? |
|
yep sounds good! |
This was referenced Nov 7, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes QC for the vaquita species (#1525) and 2 epoch demographic model (#1530). I'm currently failing a strange test related to the parameter table for an AnaPla demographic model so hoping to get some help to figure out why.
Its been a while since I've made any contributions to stdpopsim so apologies if I have messed anything up in the workflow...