Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some wands showing up in all creative tabs #96

Merged
merged 1 commit into from
Feb 3, 2019
Merged

fix some wands showing up in all creative tabs #96

merged 1 commit into from
Feb 3, 2019

Conversation

Xalcon
Copy link
Contributor

@Xalcon Xalcon commented Feb 2, 2019

This should fix the issues #95, #93, #89 and #88
Only the unrestricted wands are affected since only those override Item.getSubItems() - but it doesnt check if the given tab is correct. A call to Item.isInCreativeTab() solves this.

@portablejim portablejim merged commit 3f7ead9 into portablejim:1.12 Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants