Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves our score on OIDC self-certification for
oidcc-basic-certification-test-plan
. Full compliance may be outside the scope of the broker, up for discussion. IMO, it seems like we'd have to add a bunch of complexity for little benefit.Where we still fail:
oidcc-prompt-none-logged-in
. We forwardprompt=none
when bridging to OIDC, so it should work in those cases, but it'll never work for the email loop, because the broker doesn't have login sessions.oidcc-max-age-10000
even for OIDC bridging, becausemax_age
is not forwarded. (But I only tested the email loop in general.)oidcc-id-token-hint
, because we don't implementid_token_hint
at all. I considered returning the hint as-is to the RP if it was still valid, but that idea ran into a wall. I think we could still do this by issuing a new token with the sameexp
, but we'd have to track it in a number of places.oidcc-ensure-registered-redirect-uri
andoidcc-ensure-request-object-with-redirect-uri
, because we allow any redirect URI in the client origin. The test suite expects specific redirect URIs that were registered only, but we have no registration.oidcc-server-client-secret-post
because we have no registration and thus no client secret.oidcc-refresh-token
because we don't have access tokens or refresh tokens.