Skip to content

Commit

Permalink
Merge pull request #965 from duyphaphach/master
Browse files Browse the repository at this point in the history
Issue #964: Add Issue template and Pull request template
  • Loading branch information
posabsolute authored Jul 3, 2019
2 parents 5b56031 + e7023c6 commit 85e4325
Show file tree
Hide file tree
Showing 2 changed files with 72 additions and 0 deletions.
41 changes: 41 additions & 0 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
## I'm submitting a...

<pre><code>
[ ] Bug report <!-- Please search GitHub for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request
</code></pre>

## Current behavior

<!-- Describe how the issue manifests. -->

## Expected behavior

<!-- a cards section for tips on holloween and best place to visit for holloween party -->
<!-- glowing fonts using CSS keyframes -->

## Minimal reproduction of the problem with instructions

## If this is a feature request please fill out the following:

<pre><code>
As a (user, developer, contributor, etc):
I want:
So that:
<!-- Describe the motivation or the concrete use case. -->
</code></pre>

## Environment

<pre><code>
Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
</code></pre>
31 changes: 31 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# jQuery Validation Engine PR Request Template

#### Please note: Has this feature already been added? Sometimes, duplicate pull requests happen. It's worth checking the pull requests and issue page to see if the change you are requesting has already been made.

#### Descriptive name.
Your pull request should have a descriptive name.

#### Type of Change was Made?
What type of change does your code introduce? After creating the PR, tick the checkboxes that apply.
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Improvement (Enhance an existing functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)

#### Description of the Change Being Made.
It's helpful to outline what changes were made to which files so that I have an idea of what will be involved in reviewing the code and—hopefully—merging it into the codebase.

#### Issue Number
If your pull request is related to a specific issue, please included it in your description and or pull request name. It helps to keep changes linked. Any issues that are referenced in pull requests become part of the discussion history of the issue.

#### Potential Performance Issues
Does the PR have a potential impact on performance on the codebase? If so, to what degree and why does the PR warrant the performance hit?

#### Tests/Checks
What tests were conducted to ensure the PR functions have no impact on previous functionalities of the code base?

#### New Dependencies
Have new dependencies been introduced? Please list them with links to documentation and add installation steps to the README.



0 comments on commit 85e4325

Please sign in to comment.