Use an RwLock for AUXILIARY_EVENT_TX
#668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We expect it to be write locked very rarely, so it should still be pretty cheap to get access to this safely
lionel-
approved these changes
Jan 17, 2025
crates/ark/src/lsp/main_loop.rs
Outdated
| *tx = Some(auxiliary_event_tx); | ||
| }, | ||
| Err(error) => { | ||
| log::error!("Failed to set auxiliary event channel. {error}"); |
There was a problem hiding this comment.
I'd unwrap that since it means the auxiliary loop thread panicked, i.e. something very wrong happened?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #661
We expect it to be write locked very rarely, so it should still be pretty cheap to get access to this safely
As we saw in tracing-subscriber, this is the same kind of mechanism that the layer "handle" uses internally, so hopefully the overhead is quite low.