fix: support pl.UInt
type in nanoplot
#577
Open
+26
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #571
It seems the issue stems from the input being a type we didn’t anticipate. While more advanced types like
pl.Enum
,pl.Categorical
,pl.Array
,pl.List
orpl.Struct
could introduce additional complexity, this PR addresses the simpler part for now.Since
_str_detect()
is clearly an internal function, we could consider modifying it. However, if we switch to usingre.search()
, the following test cases will fail:If we opt not to modify
_str_detect()
, we need to handleuint
as a numerical type, as implemented in this PR.Additionally, I noticed that the alignment of
pl.UInt
might require adjustment.