e2e-test: fix notebook-create flakes #5976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 ? |
midleman
commented
Jan 13, 2025
Comment on lines
+44
to
+48
| // Wait for the desired kernel to populate in dropdown, if no show then wait for "Select Kernel" | ||
| const kernelLabelLocator = this.code.driver.page.locator(KERNEL_LABEL); | ||
| try { | ||
| await expect(kernelLabelLocator).toHaveText(new RegExp(desiredKernel), { timeout: 10000 }); | ||
| } catch (e) { |
There was a problem hiding this comment.
This snippet was the main change. Most of the time of dropdown populates with the kernel and the tests resumes. But in a flaky trace, I noticed that "Select Kernel" would first appear and then it populated the desired kernel value. This doesn't always happen, but it explains why sometimes it was unable to interact with the elements down below. It thought it wasn't selected, but it was. Modified to make it more explicit and first wait for desired kernel, and then if that doesn't happen, we can resume to selecting one.
There was a problem hiding this comment.
Worth a try! This function is painful!
jonvanausdeln
previously approved these changes
Jan 13, 2025
midleman
dismissed stale reviews from testlabauto and jonvanausdeln
via
8e3295f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Trying to fix flakes on
notebook-create.test.ts.QA Notes
✅ Ran 10x on Linux
@:notebook