Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: add Python 3.13 testing in CI #6108

Merged
merged 9 commits into from
Jan 24, 2025
Merged

python: add Python 3.13 testing in CI #6108

merged 9 commits into from
Jan 24, 2025

Conversation

isabelizimm
Copy link
Contributor

@isabelizimm isabelizimm commented Jan 23, 2025

In an effort to get testing available for Python 3.13, let's skip the tests for ibis, since it cannot be downloaded for 3.13 anyway.

Release Notes

New Features

Bug Fixes

  • N/A

QA Notes

should pass CI

Copy link

github-actions bot commented Jan 23, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

@@ -42,11 +43,6 @@
)
from .utils import get_type_as_str

try:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

torch is well supported for 3.12 now, removing old code 😬

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think is a good strategy to avoid these kinds of skips being kept around too long moving forward? Open an issue and putting it in a milestone a bit in the future?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The good thing about these is that they are pretty benign; that is, once we're at a state where x_package is installed, the test will automatically start running.

I think an issue in a milestone would be helpful! I bet some sort of standard overlay/comment to help us search for what needs to be updated would be helpful too. Even if it's something as simple as # TODO: 3.13 maint or similar.

@isabelizimm isabelizimm marked this pull request as ready for review January 23, 2025 21:51
@isabelizimm isabelizimm changed the title python: add in Python 3.13 testing in CI python: add Python 3.13 testing in CI Jan 23, 2025
@isabelizimm
Copy link
Contributor Author

CI Failure unrelated to this branch and should be fixed in #6110

…equirements.txt

Co-authored-by: Wasim Lorgat <[email protected]>
Signed-off-by: Isabel Zimmerman <[email protected]>
@isabelizimm isabelizimm merged commit 4b958a9 into main Jan 24, 2025
28 checks passed
@isabelizimm isabelizimm deleted the support-py-313 branch January 24, 2025 18:20
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants