-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python: add Python 3.13 testing in CI #6108
Conversation
E2E Tests 🚀 |
@@ -42,11 +43,6 @@ | |||
) | |||
from .utils import get_type_as_str | |||
|
|||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
torch is well supported for 3.12 now, removing old code 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think is a good strategy to avoid these kinds of skips being kept around too long moving forward? Open an issue and putting it in a milestone a bit in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The good thing about these is that they are pretty benign; that is, once we're at a state where x_package
is installed, the test will automatically start running.
I think an issue in a milestone would be helpful! I bet some sort of standard overlay/comment to help us search for what needs to be updated would be helpful too. Even if it's something as simple as # TODO: 3.13 maint
or similar.
CI Failure unrelated to this branch and should be fixed in #6110 |
extensions/positron-python/python_files/positron/pinned-test-requirements.txt
Outdated
Show resolved
Hide resolved
extensions/positron-python/python_files/positron/positron_ipykernel/tests/test_inspectors.py
Outdated
Show resolved
Hide resolved
extensions/positron-python/python_files/positron/positron_ipykernel/tests/test_inspectors.py
Outdated
Show resolved
Hide resolved
…equirements.txt Co-authored-by: Wasim Lorgat <[email protected]> Signed-off-by: Isabel Zimmerman <[email protected]>
In an effort to get testing available for Python 3.13, let's skip the tests for ibis, since it cannot be downloaded for 3.13 anyway.
Release Notes
New Features
Bug Fixes
QA Notes
should pass CI