Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cancel button from deploy progress notification #2514

Closed
wants to merge 1 commit into from

Conversation

sagerb
Copy link
Collaborator

@sagerb sagerb commented Jan 7, 2025

Intent

Resolves #2498
Resolves #2179 (by eliminating the triggering functionality)

Type of Change

    • Bug Fix
    • New Feature
    • Breaking Change
    • Documentation
    • Refactor
    • Tooling

Approach

Code was added within PR: #2071, so I used it as a guide in removing the applicable functionality. I maintained a few minor changes from that PR not directly related to the removed functionality which improved readability.

Deployment in progress now looks like this:
2025-01-07 at 9 21 AM

(Note that the screenshot was taken ahead of the incremental progress steps being displayed.)

User Impact

Users will no longer have a "Cancel" option when deploying a project to Connect.

Automated Tests

No impact to existing unit tests was needed, as the code removed did not have coverage.

Directions for Reviewers

Confirm deployment of a project:

  • is still functional
  • displays the deployment notification without a cancel button
  • continues to display the deployment progress within the home view

Checklist

@sagerb sagerb self-assigned this Jan 7, 2025
@sagerb
Copy link
Collaborator Author

sagerb commented Jan 9, 2025

We're going in a different direction after a discussion during the project planning meeting on 1/7.

@sagerb sagerb closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant