-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify debugging the agent and the extension at the same time (full-stack) #2516
Simplify debugging the agent and the extension at the same time (full-stack) #2516
Conversation
…ate from required locations for development
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of my review comments are nitpicks or questions. This is fantastic. Thanks for putting the work into this to make it easier to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the notes for how to accomplish simultaneous debugging 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes, and for getting this in. It will be so helpful 🎉
… of the UX and the agent
Intent
This PR updates the launch configuration for the vscode extension, to have two targets:
Debug with internal API agent
Debug with external API agent on 9001
The first one maintains the functionality we had before, but the second one supports the ability to launch the VSCode extension so that it expects there is an external (independently managed) API agent at port 9001.
services.ts
has been updated to implement this functionality, but by default, will continue its prior behavior of managing the agent process itself. The functionality is protected by also checking that it has been launched in development mode so that we will not have this functionality leak out to customers.I have updated the
extensions/vscode/CONTRIBUTING.md
file to reflect these changes.Type of Change
User Impact
Functionality is not exposed to customers by limiting extension logic to require execution in development mode.
Automated Tests
Not applicable
Directions for Reviewers
Debug with internal API agent
extensions/vscode/CONTRIBUTING.md
forDebug with external API agent on 9001
.vsix
file into a normal running VSCode instance. Confirm that the extension launches and talks with the agent, by viewing activity within the Publisher Output window.Checklist